From: Bjorn Helgaas <helgaas@kernel.org>
To: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"logang@deltatee.com" <logang@deltatee.com>
Subject: Re: [PATCH v3 1/1] PCI: Fix bug resulting in double hpmemsize being assigned to MMIO window
Date: Tue, 19 Nov 2019 07:38:28 -0600 [thread overview]
Message-ID: <20191119133828.GA171084@google.com> (raw)
In-Reply-To: <PS2P216MB07556573D454EB9A6D1A5140804C0@PS2P216MB0755.KORP216.PROD.OUTLOOK.COM>
On Tue, Nov 19, 2019 at 03:17:04AM +0000, Nicholas Johnson wrote:
> I did just discover linux-next and I built it. Should I be doing this
> more often to help find regressions?
Yes, if you build and run linux-next, that's a great service because
it helps find problems before they appear in mainline.
> I will now concentrate on fixing the problem where pci=nocrs does not
> ignore the bus resource. One motherboard I own gives 00-7e or similar,
> instead of 00-ff. The nocrs does not help, and I had to patch the kernel
> myself. Only acpi=off fixes the problem, while knocking out SMT (MADT),
> IOMMU (DMAR) and the ability to suspend without crashing.
>
> If you disagree that nocrs should override bus resource, then let me
> know and I will not attempt this.
I guess the problem is that with "pci=nocrs", we ignore the MMIO and
I/O port resources from _CRS, but we still pay attention to bus number
resources in _CRS? That does sound like it would be unexpected
behavior.
I *would* like to see the complete dmesg log because these _CRS
methods are pretty reliable because Windows relies on them as well, so
problems are frequently a result of Linux defects. If we can fix
Linux or automatically work around issues so users don't have to use
"pci=nocrs" explicitly, that's the best.
Bjorn
next prev parent reply other threads:[~2019-11-19 13:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 15:25 [PATCH v3 1/1] PCI: Fix bug resulting in double hpmemsize being assigned to MMIO window Nicholas Johnson
2019-11-13 16:50 ` Logan Gunthorpe
2019-11-14 16:56 ` Bjorn Helgaas
2019-11-16 2:54 ` Nicholas Johnson
2019-11-18 9:43 ` Nicholas Johnson
2019-11-18 22:58 ` Bjorn Helgaas
2019-11-19 3:17 ` Nicholas Johnson
2019-11-19 13:38 ` Bjorn Helgaas [this message]
2019-11-21 14:52 ` Nicholas Johnson
2019-11-21 17:55 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119133828.GA171084@google.com \
--to=helgaas@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mika.westerberg@linux.intel.com \
--cc=nicholas.johnson-opensource@outlook.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).