From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A55EDC43215 for ; Tue, 19 Nov 2019 15:48:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D058222CD for ; Tue, 19 Nov 2019 15:48:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574178523; bh=kcA2P8vKFoTMbflqHG8Tbx8oh+/xVrVVvWbHcEx7O9k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Ark8vCPaosF4dwvdcOZwfrAIwxoaynqARi53tJCTZIkJBxL1+c/T6zdfbgao43xtq SAu0bNJPyJdpYVeODrAan7vVNkwSMt8lo08rDyFbTLvXMA30GhxjvbO5RvLy+NaQHG gAKqVXJKLSgkEVlV6DgAmK/dd7ys4pVs7meqJwjE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728372AbfKSPsm (ORCPT ); Tue, 19 Nov 2019 10:48:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:52948 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727937AbfKSPsm (ORCPT ); Tue, 19 Nov 2019 10:48:42 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9CB7A222A2; Tue, 19 Nov 2019 15:48:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574178521; bh=kcA2P8vKFoTMbflqHG8Tbx8oh+/xVrVVvWbHcEx7O9k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cAzfSPD2h/BLkljt3q9zERzLdZxeQ6I1oABOjgAPnvJtcsqj4FTCDTKgmVdycJyQk I/xXUAXvllzwNM9KKjcH8t42XLXD5idNFpuxPX2fbaYcB4qCItvVkzErgKyJ64rGRr 6O8uyw1flgb9TRMaDeWGLKeNqaRzmnhNMJ+qx8ho= Date: Tue, 19 Nov 2019 16:48:39 +0100 From: Greg Kroah-Hartman To: Chris Paterson Cc: "linux-kernel@vger.kernel.org" , "cip-dev@lists.cip-project.org" , "torvalds@linux-foundation.org" , "akpm@linux-foundation.org" , "linux@roeck-us.net" , "shuah@kernel.org" , "patches@kernelci.org" , "ben.hutchings@codethink.co.uk" , "lkft-triage@lists.linaro.org" , "stable@vger.kernel.org" Subject: Re: [PATCH 4.19 000/422] 4.19.85-stable review Message-ID: <20191119154839.GB1982025@kroah.com> References: <20191119051400.261610025@linuxfoundation.org> <20191119122909.GC1913916@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 19, 2019 at 02:44:12PM +0000, Chris Paterson wrote: > Hi Greg, > > > From: Greg Kroah-Hartman > > Sent: 19 November 2019 12:29 > > > > On Tue, Nov 19, 2019 at 08:54:25AM +0000, Chris Paterson wrote: > > > Hello Greg, all, > > > > > > > From: stable-owner@vger.kernel.org On > > > > Behalf Of Greg Kroah-Hartman > > > > Sent: 19 November 2019 05:13 > > > > > > > > This is the start of the stable review cycle for the 4.19.85 release. > > > > There are 422 patches in this series, all will be posted as a response > > > > to this one. If anyone has any issues with these being applied, please > > > > let me know. > > > > > > I'm seeing some build issues with module compilation with this release > > (1b1960cc Linux 4.19.85-rc1), I also saw them with the previous two versions of > > Linux 4.19.85-rc1 (cd21ecdb and 1fd0ac64). > > > > > > Full log available on GitLab [0]. Build conf [1]. > > > [0] https://gitlab.com/cip-playground/linux-stable-rc-ci/-/jobs/354591285 > > > [1] https://gitlab.com/cip-playground/linux-stable-rc-ci/- > > /jobs/354591285/artifacts/file/output/4.19.85- > > rc1_1b1960cc7/x86/siemens_iot2000.config/config/.config > > > > > > Main error below: > > > > > > 3907 CC [M] drivers/net/ethernet/mellanox/mlx4/main.o > > > 3908 LD [M] fs/ntfs/ntfs.o > > > 3909 CC [M] drivers/net/ethernet/intel/i40evf/i40e_txrx.o > > > 3910 CC [M] drivers/usb/musb/musb_core.o > > > 3911 CC [M] drivers/net/ethernet/nvidia/forcedeth.o > > > 3912 CC [M] fs/udf/balloc.o > > > 3913 CC [M] drivers/net/ethernet/intel/fm10k/fm10k_debugfs.o > > > 3914 CC [M] fs/udf/dir.o > > > 3915 CC [M] drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.o > > > 3916 CC [M] drivers/net/ethernet/intel/i40e/i40e_ptp.o > > > 3917 drivers/net/ethernet/mellanox/mlx4/main.c: In function 'mlx4_init_one': > > > 3918 drivers/net/ethernet/mellanox/mlx4/main.c:3985:2: error: implicit > > declaration of function 'devlink_reload_enable'; did you mean > > 'devlink_region_create'? [-Werror=implicit-function-declaration] > > > 3919 devlink_reload_enable(devlink); > > > 3920 ^~~~~~~~~~~~~~~~~~~~~ > > > 3921 devlink_region_create > > > 3922 CC [M] drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.o > > > 3923 drivers/net/ethernet/mellanox/mlx4/main.c: In function > > 'mlx4_remove_one': > > > 3924 drivers/net/ethernet/mellanox/mlx4/main.c:4097:2: error: implicit > > declaration of function 'devlink_reload_disable'; did you mean > > 'devlink_region_destroy'? [-Werror=implicit-function-declaration] > > > 3925 devlink_reload_disable(devlink); > > > 3926 ^~~~~~~~~~~~~~~~~~~~~~ > > > 3927 devlink_region_destroy > > > 3928 CC [M] drivers/net/ethernet/packetengines/hamachi.o > > > 3929 CC [M] fs/udf/file.o > > > 3930 LD [M] drivers/net/ethernet/intel/fm10k/fm10k.o > > > > > > I haven't tried to trace the issue further yet, sorry. > > > > Any chance you can bisect this? I don't see any obvious reason why this > > error should be happening, and it isn't showing up here :( > > Looking through the commit history, the issue seems to be related to: > 672cf82122be ("devlink: disallow reload operation during device cleanup") > > I've reverted this commit and Linux 4.19.85-rc2 (af1bb7db before revert) will build with the configuration I'm using [2]. > I haven't looked further yet though, sorry. > > [2] https://gitlab.com/cip-project/cip-kernel/cip-kernel-config/raw/master/4.19.y-cip/x86/siemens_iot2000.config If you add: #include to the top of drivers/net/ethernet/mellanox/mlx4/main.c, does it fix the issue for you? If so, I'll modify the file to have that, seems to be some sort of include file mess :( thanks, greg k-h