From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89BE0C432C0 for ; Tue, 3 Dec 2019 22:44:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52AB8206EC for ; Tue, 3 Dec 2019 22:44:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413047; bh=nAX1jztnTArJns5G3zDXl5/umt/1KT8SVroE95f7pao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=amoT5ptlHvvsWO7y0IhnL4Jrg4cvDT6jNtEdfm9BmxEbp7k+TX8KKPbPqQFdmBgDc UZhzaSy5Gr+CTWry9KPAYkMUoQsDUbV92tknwDxWOkM4phjGPt1l5mwjWf6/OdQBpf gQGfDPPAUqWjoNRp0TMC0Z2VjgZtaYJkEjzTq/TQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728915AbfLCWoF (ORCPT ); Tue, 3 Dec 2019 17:44:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:59738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728897AbfLCWoD (ORCPT ); Tue, 3 Dec 2019 17:44:03 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AA5162073C; Tue, 3 Dec 2019 22:44:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413043; bh=nAX1jztnTArJns5G3zDXl5/umt/1KT8SVroE95f7pao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aUfIx4EbURUmg5rYYkHHxCsK/goKbmUrj5UsqDRZMtZ0Zk1YGnFyoIyJQpJPvrjo5 cezuLMJpnC4JVeAt4H06wADmscF7WDaYqaA6myzDWtYwK+XsEIOqjnjzI5vyzo0CqW ofvHWgnA61iBDuMFRA3qVHWF5ACyJwe8H9zzh+M0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , "David S. Miller" Subject: [PATCH 5.3 113/135] net: macb: add missed tasklet_kill Date: Tue, 3 Dec 2019 23:35:53 +0100 Message-Id: <20191203213042.298448731@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203213005.828543156@linuxfoundation.org> References: <20191203213005.828543156@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan [ Upstream commit 61183b056b49e2937ff92a1424291ba36a6f6d05 ] This driver forgets to kill tasklet in remove. Add the call to fix it. Fixes: 032dc41ba6e2 ("net: macb: Handle HRESP error") Signed-off-by: Chuhong Yuan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/cadence/macb_main.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4393,6 +4393,7 @@ static int macb_remove(struct platform_d mdiobus_free(bp->mii_bus); unregister_netdev(dev); + tasklet_kill(&bp->hresp_err_tasklet); pm_runtime_disable(&pdev->dev); pm_runtime_dont_use_autosuspend(&pdev->dev); if (!pm_runtime_suspended(&pdev->dev)) {