From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EAB4C432C0 for ; Tue, 3 Dec 2019 22:47:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED13720684 for ; Tue, 3 Dec 2019 22:47:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413221; bh=Tyhi2JPw7jneTFeLl7BLrdgROznfz5UAxCjic14lyyE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Rww+f/VqdazVFzsKLC3SnEfddI4TvLFEM4bwmvEH6NrqGdlI6EcnwJszezElxd6dH 1gTF2WhdHMSwPbVZSVEYoSH6VnuCP9eY7wPxrmHwcc8QtOMdAen/KUi1fQbnFVS5MS ckkS6agIWICK2F6qlCpUX7JQ1A9KYmUXfEu1IU9o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729256AbfLCWq7 (ORCPT ); Tue, 3 Dec 2019 17:46:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:36762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729251AbfLCWqv (ORCPT ); Tue, 3 Dec 2019 17:46:51 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D98D2084B; Tue, 3 Dec 2019 22:46:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413211; bh=Tyhi2JPw7jneTFeLl7BLrdgROznfz5UAxCjic14lyyE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2lkMzGuGfMqOrmyMhQIcTISTmK4Ls3qjdZzSSx/hIS3SJe0LVzxTF9wGdhJdYC4aa K+Ad7lGtfgzQ70riuftSwUp6v4pHASUI8Yn/merpnleGwQ0g3sOfQp/4sM6hm8K+nq aKyQM+oAVmusVs3F9Qh6K5ODSHXCZGpAs/y8e84c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xiaojun Sang , Srinivas Kandagatla , Vinod Koul , Mark Brown , Sasha Levin Subject: [PATCH 4.19 004/321] ASoC: compress: fix unsigned integer overflow check Date: Tue, 3 Dec 2019 23:31:10 +0100 Message-Id: <20191203223427.350424112@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203223427.103571230@linuxfoundation.org> References: <20191203223427.103571230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiaojun Sang [ Upstream commit d3645b055399538415586ebaacaedebc1e5899b0 ] Parameter fragments and fragment_size are type of u32. U32_MAX is the correct check. Signed-off-by: Xiaojun Sang Signed-off-by: Srinivas Kandagatla Acked-by: Vinod Koul Link: https://lore.kernel.org/r/20191021095432.5639-1-srinivas.kandagatla@linaro.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/core/compress_offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c index 516ec35873256..509038d6bccdb 100644 --- a/sound/core/compress_offload.c +++ b/sound/core/compress_offload.c @@ -529,7 +529,7 @@ static int snd_compress_check_input(struct snd_compr_params *params) { /* first let's check the buffer parameter's */ if (params->buffer.fragment_size == 0 || - params->buffer.fragments > INT_MAX / params->buffer.fragment_size || + params->buffer.fragments > U32_MAX / params->buffer.fragment_size || params->buffer.fragments == 0) return -EINVAL; -- 2.20.1