From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7225EC432C0 for ; Tue, 3 Dec 2019 22:52:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35C9D214AF for ; Tue, 3 Dec 2019 22:52:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413562; bh=uBfze1NgWAGObk+4YKV9h++cdjQx83W+ZcE+McTkqCo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tY9mnlPlVSdN5apmXxdF1UBmB7jRV6eqqpGB8imZbC439Czg+fGOgLUnX7DUGoOsL ZKwnl+j2vdRfCOETf7JOzPvCang9GiXDcdj+1QmD2w3FqQe3p70xyKeJIq1yMxelwo UUpDBj/+meUw12mu+5au6WCXxDY/e4GSLaYGlFY4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729925AbfLCWwl (ORCPT ); Tue, 3 Dec 2019 17:52:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:45450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730034AbfLCWwh (ORCPT ); Tue, 3 Dec 2019 17:52:37 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A16CB2053B; Tue, 3 Dec 2019 22:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413557; bh=uBfze1NgWAGObk+4YKV9h++cdjQx83W+ZcE+McTkqCo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fsXHdsVYw6WhNhkBocQrPlhxnrn1Eq6SaUuAjcD9BMkIpZGGKL8L6jj1DK95ZggNi J3S2KekWeYE2zFxsT+4T/uyqTOkSyDA+sF8Nh9CUNUrKn9olXCS3cUHNCwg+nn7E9+ jDi3fvyVAACx7eUZn8WMXxPE0I4kiLl6X9QHg02E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Saeed Mahameed , Leon Romanovsky , Sasha Levin Subject: [PATCH 4.19 133/321] net/mlx5: Continue driver initialization despite debugfs failure Date: Tue, 3 Dec 2019 23:33:19 +0100 Message-Id: <20191203223434.082320195@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203223427.103571230@linuxfoundation.org> References: <20191203223427.103571230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Leon Romanovsky [ Upstream commit 199fa087dc6b503baad06712716fac645a983e8a ] The failure to create debugfs entry is unpleasant event, but not enough to abort drier initialization. Align the mlx5_core code to debugfs design and continue execution whenever debugfs_create_dir() successes or not. Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters") Reviewed-by: Saeed Mahameed Signed-off-by: Leon Romanovsky Signed-off-by: Saeed Mahameed Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c index 231ed508c240a..5fac00ea62457 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c @@ -859,11 +859,9 @@ static int mlx5_pci_init(struct mlx5_core_dev *dev, struct mlx5_priv *priv) priv->numa_node = dev_to_node(&dev->pdev->dev); - priv->dbg_root = debugfs_create_dir(dev_name(&pdev->dev), mlx5_debugfs_root); - if (!priv->dbg_root) { - dev_err(&pdev->dev, "Cannot create debugfs dir, aborting\n"); - return -ENOMEM; - } + if (mlx5_debugfs_root) + priv->dbg_root = + debugfs_create_dir(pci_name(pdev), mlx5_debugfs_root); err = mlx5_pci_enable_device(dev); if (err) { -- 2.20.1