From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1211AC432C3 for ; Tue, 3 Dec 2019 22:53:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7D242158C for ; Tue, 3 Dec 2019 22:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413585; bh=su1n9rIFco9QybKw4v3E7bYzZ5i2FUYnqUp43IBNZ6w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=uT4h+5beWTVu9Dh6rf4nBkLA2utFoivTUCzjfdPeyDgjKWspeS6ALX0WLngpahsIV HCOdOVgFY9tOUalIHGIG62/7eY+f6p3ha7DYhbA/IrfneixkPp50zCWKOmPLZC0X9w T5w+K/R4IGUERpgyCgMBoAd5M9jPDUC8hV9NL81k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730107AbfLCWxF (ORCPT ); Tue, 3 Dec 2019 17:53:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:46074 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730093AbfLCWxD (ORCPT ); Tue, 3 Dec 2019 17:53:03 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0E42D207DD; Tue, 3 Dec 2019 22:53:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413582; bh=su1n9rIFco9QybKw4v3E7bYzZ5i2FUYnqUp43IBNZ6w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x96LpU1Gf9xJn3IP+ZnEVAPaxXan4Yj20Anq3P0N4SGOs+b3JUBBpVJuLRXNqMltG V1Y8MGu+xEOQsgnalSx15632dKshe9eyEYaTfe8N7odSzVyf+psKXl09arFbeXn7QY V1FbDm7OlgFVSYqvXmDOMwt/1W/PB+fwMUNnjZz0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aditya Pakki , Kirill Tkhai , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 184/321] net/net_namespace: Check the return value of register_pernet_subsys() Date: Tue, 3 Dec 2019 23:34:10 +0100 Message-Id: <20191203223436.695979889@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203223427.103571230@linuxfoundation.org> References: <20191203223427.103571230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aditya Pakki [ Upstream commit 0eb987c874dc93f9c9d85a6465dbde20fdd3884c ] In net_ns_init(), register_pernet_subsys() could fail while registering network namespace subsystems. The fix checks the return value and sends a panic() on failure. Signed-off-by: Aditya Pakki Reviewed-by: Kirill Tkhai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/core/net_namespace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index 6dab186d4b8f6..c60123dff8039 100644 --- a/net/core/net_namespace.c +++ b/net/core/net_namespace.c @@ -913,7 +913,8 @@ static int __init net_ns_init(void) init_net_initialized = true; up_write(&pernet_ops_rwsem); - register_pernet_subsys(&net_ns_ops); + if (register_pernet_subsys(&net_ns_ops)) + panic("Could not register network namespace subsystems"); rtnl_register(PF_UNSPEC, RTM_NEWNSID, rtnl_net_newid, NULL, RTNL_FLAG_DOIT_UNLOCKED); -- 2.20.1