From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3FB3C432C0 for ; Tue, 3 Dec 2019 22:58:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C356D20863 for ; Tue, 3 Dec 2019 22:58:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413938; bh=cOpTOn6Epw/sJcpdJOqtdkwi6b0HMpyZ4aSbTlCajiI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rc2TQnaMAZ0cmTqjscJsPqbJjCydGjN/5qhRjpuvXBwxgMzGY91WPv1GcLBhCdKVJ slBXqxbcmlr5WVXsVuuaWBLOX1qy8L89tSRrcJtZG0wtnVtGDWmUyufxKOe7IRzdeO tWx6jYFfxR9Wwkdq9Yhd/wELvsl+6kRSyDFbiHFA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730723AbfLCW65 (ORCPT ); Tue, 3 Dec 2019 17:58:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:55418 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730585AbfLCW6x (ORCPT ); Tue, 3 Dec 2019 17:58:53 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61BE220866; Tue, 3 Dec 2019 22:58:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413932; bh=cOpTOn6Epw/sJcpdJOqtdkwi6b0HMpyZ4aSbTlCajiI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BS5NVQ7u6OTRbeIkDDZ6/S+7QnMJxBDiT7LB6FTAF2jePMl97k9yzQ3ATYrSkYZTr xxLYJ451mVJxWLXK1z4oWC6sc2Br+gyQVak1pOVEy3+Y3DEj/JXYgU8aRD7xZ9UZDm Y+SslbRLIEB01/LpSx2k1xU99kMeqG1fDpA3nua8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wen Yang , Olivier Moysan , Mark Brown , Mathieu Poirier Subject: [PATCH 4.19 318/321] ASoC: stm32: sai: add missing put_device() Date: Tue, 3 Dec 2019 23:36:24 +0100 Message-Id: <20191203223443.685790572@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203223427.103571230@linuxfoundation.org> References: <20191203223427.103571230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wen Yang commit 1c3816a194870e7a6622345dab7fb56c7d708613 upstream. The of_find_device_by_node() takes a reference to the underlying device structure, we should release that reference. Fixes: 7dd0d835582f ("ASoC: stm32: sai: simplify sync modes management") Signed-off-by: Wen Yang Acked-by: Olivier Moysan Signed-off-by: Mark Brown Signed-off-by: Mathieu Poirier Signed-off-by: Greg Kroah-Hartman --- sound/soc/stm/stm32_sai.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) --- a/sound/soc/stm/stm32_sai.c +++ b/sound/soc/stm/stm32_sai.c @@ -112,16 +112,21 @@ static int stm32_sai_set_sync(struct stm if (!sai_provider) { dev_err(&sai_client->pdev->dev, "SAI sync provider data not found\n"); - return -EINVAL; + ret = -EINVAL; + goto out_put_dev; } /* Configure sync client */ ret = stm32_sai_sync_conf_client(sai_client, synci); if (ret < 0) - return ret; + goto out_put_dev; /* Configure sync provider */ - return stm32_sai_sync_conf_provider(sai_provider, synco); + ret = stm32_sai_sync_conf_provider(sai_provider, synco); + +out_put_dev: + put_device(&pdev->dev); + return ret; } static int stm32_sai_probe(struct platform_device *pdev)