From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75F3BC2D0C6 for ; Wed, 11 Dec 2019 10:13:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BEB7214D8 for ; Wed, 11 Dec 2019 10:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728800AbfLKKNG (ORCPT ); Wed, 11 Dec 2019 05:13:06 -0500 Received: from foss.arm.com ([217.140.110.172]:52332 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728480AbfLKKNG (ORCPT ); Wed, 11 Dec 2019 05:13:06 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3AEAF1FB; Wed, 11 Dec 2019 02:13:05 -0800 (PST) Received: from bogus (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 521A83F6CF; Wed, 11 Dec 2019 02:13:04 -0800 (PST) Date: Wed, 11 Dec 2019 10:13:02 +0000 From: Sudeep Holla To: Viresh Kumar Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Cristian Marussi , "Rafael J. Wysocki" , linux-pm@vger.kernel.org Subject: Re: [PATCH 13/15] cpufreq: scmi: Match scmi device by both name and protocol id Message-ID: <20191211101302.GD20962@bogus> References: <20191210145345.11616-1-sudeep.holla@arm.com> <20191210145345.11616-14-sudeep.holla@arm.com> <20191211023909.7iun7kdk6pjkync6@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191211023909.7iun7kdk6pjkync6@vireshk-i7> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 11, 2019 at 08:09:09AM +0530, Viresh Kumar wrote: > On 10-12-19, 14:53, Sudeep Holla wrote: > > The scmi bus now has support to match the driver with devices not only > > based on their protocol id but also based on their device name if one is > > available. This was added to cater the need to support multiple devices > > and drivers for the same protocol. > > > > Let us add the name "cpufreq" to scmi_device_id table in the driver so > > that in matches only with device with the same name and protocol id > > SCMI_PROTOCOL_PERF. This will help to add "devfreq" device/driver. > > > > Cc: "Rafael J. Wysocki" > > Cc: Viresh Kumar > > Cc: linux-pm@vger.kernel.org > > Signed-off-by: Sudeep Holla > > --- > > drivers/cpufreq/scmi-cpufreq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c > > index e6182c89df79..61623e2ff149 100644 > > --- a/drivers/cpufreq/scmi-cpufreq.c > > +++ b/drivers/cpufreq/scmi-cpufreq.c > > @@ -261,7 +261,7 @@ static void scmi_cpufreq_remove(struct scmi_device *sdev) > > } > > > > static const struct scmi_device_id scmi_id_table[] = { > > - { SCMI_PROTOCOL_PERF }, > > + { SCMI_PROTOCOL_PERF, "cpufreq" }, > > { }, > > }; > > MODULE_DEVICE_TABLE(scmi, scmi_id_table); > > Applied. Thanks. This will break the build without patch 1/15, so preferably must go as part of the series. Sorry for not missing to specify that detail. -- Regards, Sudeep