From: Lee Jones <lee.jones@linaro.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
stefan@agner.ch, b.galvani@gmail.com, phh@phh.me,
letux-kernel@openphoenux.org
Subject: Re: [PATCH v4 4/5] mfd: rn5t618: add more subdevices
Date: Tue, 17 Dec 2019 08:01:46 +0000 [thread overview]
Message-ID: <20191217080146.GE18955@dell> (raw)
In-Reply-To: <20191216170000.022a4c31@kemnade.info>
On Mon, 16 Dec 2019, Andreas Kemnade wrote:
> On Mon, 16 Dec 2019 15:31:06 +0000
> Lee Jones <lee.jones@linaro.org> wrote:
>
> > On Wed, 11 Dec 2019, Andreas Kemnade wrote:
> >
> > > The RC5T619 has a RTC which is missing in the
> > > RN5T618. Add it as subdevice to prepare for their implementation
> > >
> > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > > ---
> > > Changes in v3:
> > > - alignment cleanup
> > > drivers/mfd/rn5t618.c | 16 ++++++++++++++--
> > > 1 file changed, 14 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c
> > > index d78eb29b94a4..18d56a732b20 100644
> > > --- a/drivers/mfd/rn5t618.c
> > > +++ b/drivers/mfd/rn5t618.c
> > > @@ -22,6 +22,12 @@ static const struct mfd_cell rn5t618_cells[] = {
> > > { .name = "rn5t618-wdt" },
> > > };
> > >
> > > +static const struct mfd_cell rc5t619_cells[] = {
> > > + { .name = "rn5t618-regulator" },
> > > + { .name = "rc5t619-rtc" },
> > > + { .name = "rn5t618-wdt" },
> > > +};
> > > +
> > > static bool rn5t618_volatile_reg(struct device *dev, unsigned int reg)
> > > {
> > > switch (reg) {
> > > @@ -173,8 +179,14 @@ static int rn5t618_i2c_probe(struct i2c_client *i2c,
> > > return ret;
> > > }
> > >
> > > - ret = devm_mfd_add_devices(&i2c->dev, -1, rn5t618_cells,
> > > - ARRAY_SIZE(rn5t618_cells), NULL, 0, NULL);
> > > + if (priv->variant == RC5T619)
> > > + ret = devm_mfd_add_devices(&i2c->dev, -1, rc5t619_cells,
> >
> > Ref: The "-1", please use this as an opportunity to use the defines.
> >
> > > + ARRAY_SIZE(rc5t619_cells),
> > > + NULL, 0, NULL);
> > > + else
> >
> > Are you sure it's not possible for 'variant' to be an unsupported
> > device?
> >
> Well, does it change the behavior for devices other than the rc5t619?
> I do not think so. If the mfd driver is bound to unsupported devices,
> rn5t618_of_match is wrong.
Right, and can you catch that?
> Or do you want separate cell arrays for each of the three variant now to
> ease future extensions?
No need for that, thank you.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-12-17 8:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 21:54 [PATCH v4 0/5] Add rtc support for rn5t618 mfd Andreas Kemnade
2019-12-11 21:54 ` [PATCH v4 1/5] dt-bindings: mfd: rn5t618: Document optional property interrupts Andreas Kemnade
2019-12-16 15:27 ` Lee Jones
2019-12-18 20:54 ` Rob Herring
2019-12-11 21:54 ` [PATCH v4 2/5] mfd: rn5t618: add IRQ support Andreas Kemnade
2019-12-16 15:27 ` Lee Jones
2019-12-16 16:01 ` Andreas Kemnade
2019-12-11 21:54 ` [PATCH v4 3/5] mfd: rn5t618: add RTC related registers Andreas Kemnade
2019-12-16 15:28 ` Lee Jones
2019-12-11 21:54 ` [PATCH v4 4/5] mfd: rn5t618: add more subdevices Andreas Kemnade
2019-12-16 15:31 ` Lee Jones
2019-12-16 16:00 ` Andreas Kemnade
2019-12-17 8:01 ` Lee Jones [this message]
2019-12-17 11:25 ` Andreas Kemnade
2019-12-17 19:26 ` Andreas Kemnade
2019-12-11 21:54 ` [PATCH v4 5/5] rtc: rc5t619: add ricoh rc5t619 RTC driver Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217080146.GE18955@dell \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=andreas@kemnade.info \
--cc=b.galvani@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=phh@phh.me \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).