From: Tan Xiaojun <tanxiaojun@huawei.com>
To: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<alexander.shishkin@linux.intel.com>, <jolsa@redhat.com>,
<namhyung@kernel.org>, <ak@linux.intel.com>,
<adrian.hunter@intel.com>, <yao.jin@linux.intel.com>,
<tmricht@linux.ibm.com>, <brueckner@linux.ibm.com>,
<songliubraving@fb.com>, <gregkh@linuxfoundation.org>,
<kim.phillips@arm.com>, <James.Clark@arm.com>,
<jeremy.linton@arm.com>
Cc: <gengdongjiu@huawei.com>, <wxf.wang@hisilicon.com>,
<liwei391@huawei.com>, <tanxiaojun@huawei.com>,
<liuqi115@hisilicon.com>, <huawei.libin@huawei.com>,
<linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>
Subject: [PATCH 6/6] perf tools: arm-spe: fix record hang after being terminated
Date: Wed, 18 Dec 2019 15:54:55 +0800 [thread overview]
Message-ID: <20191218075455.5106-7-tanxiaojun@huawei.com> (raw)
In-Reply-To: <20191218075455.5106-1-tanxiaojun@huawei.com>
From: Wei Li <liwei391@huawei.com>
If the spe event is terminated, we don't enable it again here.
Signed-off-by: Wei Li <liwei391@huawei.com>
Tested-by: Qi Liu <liuqi115@hisilicon.com>
---
tools/perf/arch/arm64/util/arm-spe.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/util/arm-spe.c
index eba6541ec0f1..629badda724d 100644
--- a/tools/perf/arch/arm64/util/arm-spe.c
+++ b/tools/perf/arch/arm64/util/arm-spe.c
@@ -165,9 +165,13 @@ static int arm_spe_read_finish(struct auxtrace_record *itr, int idx)
struct evsel *evsel;
evlist__for_each_entry(sper->evlist, evsel) {
- if (evsel->core.attr.type == sper->arm_spe_pmu->type)
- return perf_evlist__enable_event_idx(sper->evlist,
- evsel, idx);
+ if (evsel->core.attr.type == sper->arm_spe_pmu->type) {
+ if (evsel->terminated)
+ return 0;
+ else
+ return perf_evlist__enable_event_idx(
+ sper->evlist, evsel, idx);
+ }
}
return -EINVAL;
}
--
2.17.1
next prev parent reply other threads:[~2019-12-18 7:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 7:54 [PATCH 0/6] perf tools: Add support for some spe events and precise ip Tan Xiaojun
2019-12-18 7:54 ` [PATCH 1/6] perf tools: Move arm-spe-pkt-decoder.h/c to the new dir Tan Xiaojun
2019-12-18 7:54 ` [PATCH 2/6] perf tools: Add support for "report" for some spe events Tan Xiaojun
2019-12-18 7:54 ` [PATCH 3/6] perf report: Add --spe options for arm-spe Tan Xiaojun
2019-12-18 7:54 ` [PATCH 4/6] perf tools: Support "branch-misses:pp" on arm64 Tan Xiaojun
2019-12-18 7:54 ` [PATCH 5/6] perf tools: add perf_evlist__terminate() for terminate Tan Xiaojun
2019-12-18 7:54 ` Tan Xiaojun [this message]
2020-01-15 12:02 ` [PATCH 6/6] perf tools: arm-spe: fix record hang after being terminated James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218075455.5106-7-tanxiaojun@huawei.com \
--to=tanxiaojun@huawei.com \
--cc=James.Clark@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=brueckner@linux.ibm.com \
--cc=gengdongjiu@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=huawei.libin@huawei.com \
--cc=jeremy.linton@arm.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=liuqi115@hisilicon.com \
--cc=liwei391@huawei.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=tmricht@linux.ibm.com \
--cc=wxf.wang@hisilicon.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).