From: Rob Herring <robh@kernel.org>
To: Taniya Das <tdas@codeaurora.org>
Cc: "Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette " <mturquette@baylibre.com>,
"David Brown" <david.brown@linaro.org>,
"Rajendra Nayak" <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
"Andy Gross" <agross@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings
Date: Sat, 4 Jan 2020 14:36:45 -0700 [thread overview]
Message-ID: <20200104213645.GA25711@bogus> (raw)
In-Reply-To: <1577421760-1174-2-git-send-email-tdas@codeaurora.org>
On Fri, Dec 27, 2019 at 10:12:38AM +0530, Taniya Das wrote:
> The MSS clock provider have a bunch of generic properties that
> are needed in a device tree. Add a YAML schemas for those.
>
> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> ---
> .../devicetree/bindings/clock/qcom,mss.yaml | 41 ++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,mss.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,mss.yaml b/Documentation/devicetree/bindings/clock/qcom,mss.yaml
> new file mode 100644
> index 0000000..05efe2b2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,mss.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bindings/clock/qcom,mss.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Modem Clock Controller Binding
> +
> +maintainers:
> + - Taniya Das <tdas@codeaurora.org>
> +
> +description: |
> + Qualcomm modem clock control module which supports the clocks.
> +
> +properties:
> + compatible :
drop space ^
> + enum:
> + - qcom,sc7180-mss
> +
> + '#clock-cells':
> + const: 1
> +
> + reg:
> + maxItems: 1
> +
> + additionalItems: false
With the indentation here, you are defining a property. Should be no
indent.
> +
> +required:
> + - compatible
> + - reg
> + - '#clock-cells'
> +
> +examples:
> + # Example of MSS with clock nodes properties for SC7180:
> + - |
> + clock-controller@41aa000 {
> + compatible = "qcom,sc7180-mss";
> + reg = <0x041aa000 0x100>;
> + #clock-cells = <1>;
> + };
> +...
> --
> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
> of the Code Aurora Forum, hosted by the Linux Foundation.
>
next prev parent reply other threads:[~2020-01-04 21:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 4:42 [PATCH v2 0/3] Add modem Clock controller (MSS CC) driver for SC7180 Taniya Das
2019-12-27 4:42 ` [PATCH v2 1/3] dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings Taniya Das
2019-12-27 7:01 ` Sibi Sankar
2020-01-13 9:56 ` Taniya Das
2020-01-04 21:36 ` Rob Herring [this message]
2020-01-13 10:00 ` Taniya Das
2020-01-13 16:21 ` Rob Herring
2019-12-27 4:42 ` [PATCH v2 2/3] dt-bindings: clock: Introduce QCOM Modem " Taniya Das
2019-12-27 4:42 ` [PATCH v2 3/3] clk: qcom: Add modem clock controller driver for SC7180 Taniya Das
2019-12-27 7:20 ` Sibi Sankar
2020-01-13 10:04 ` Taniya Das
2020-01-22 21:29 ` Doug Anderson
2019-12-30 18:02 ` [PATCH v2 0/3] Add modem Clock controller (MSS CC) " Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200104213645.GA25711@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).