From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-arm-msm@vger.kernel.org, Suman Anna <s-anna@ti.com>,
Fabien DESSENNE <fabien.dessenne@st.com>,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v2] rpmsg: core: add API to get MTU
Date: Mon, 13 Jan 2020 09:24:53 -0800 [thread overview]
Message-ID: <20200113172453.GQ738324@yoga> (raw)
In-Reply-To: <20191113172249.32412-1-arnaud.pouliquen@st.com>
On Wed 13 Nov 09:22 PST 2019, Arnaud Pouliquen wrote:
> Return the rpmsg buffer MTU for sending message, so rpmsg users
> can split a long message in several sub rpmsg buffers.
>
I won't merge this new api without a client, and I'm still concerned
about the details.
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
> ---
> V1 to V2
>
> V1 patch:https://lore.kernel.org/patchwork/patch/1124684/
> - Change patch title,
> - as not solution today to support MTU on GLINK make ops optional,
> RPMsg client API returns -ENOTSUPP in this case,
> - suppress smd and glink patches.
That's ok.
> ---
> drivers/rpmsg/rpmsg_core.c | 21 +++++++++++++++++++++
> drivers/rpmsg/rpmsg_internal.h | 2 ++
> drivers/rpmsg/virtio_rpmsg_bus.c | 10 ++++++++++
> include/linux/rpmsg.h | 10 ++++++++++
> 4 files changed, 43 insertions(+)
>
> diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
> index e330ec4dfc33..a6ef54c4779a 100644
> --- a/drivers/rpmsg/rpmsg_core.c
> +++ b/drivers/rpmsg/rpmsg_core.c
> @@ -283,6 +283,27 @@ int rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, u32 dst,
> }
> EXPORT_SYMBOL(rpmsg_trysend_offchannel);
>
> +/**
> + * rpmsg_get_mtu() - get maximum transmission buffer size for sending message.
> + * @ept: the rpmsg endpoint
> + *
> + * This function returns maximum buffer size available for a single message.
> + *
> + * Return: the maximum transmission size on success and an appropriate error
> + * value on failure.
Is the expectation that a call to rpmsg_send() with this size will
eventually succeed?
> + */
[..]
> +static ssize_t virtio_rpmsg_get_mtu(struct rpmsg_endpoint *ept)
> +{
> + struct rpmsg_device *rpdev = ept->rpdev;
> + struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev);
> +
> + return vch->vrp->buf_size - sizeof(struct rpmsg_hdr);
I'm still under the impression that the rpmsg protocol doesn't have to
operate on fixed size messages. Would this then return vrp->num_bufs *
vrp->buf_size / 2 - sizeof(rpmsg_hdr)?
> +}
> +
Regards,
Bjorn
next prev parent reply other threads:[~2020-01-13 17:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 17:22 [PATCH v2] rpmsg: core: add API to get MTU Arnaud Pouliquen
2020-01-13 13:19 ` Arnaud POULIQUEN
2020-01-14 23:40 ` Suman Anna
2020-01-15 7:56 ` Arnaud POULIQUEN
2020-01-13 17:24 ` Bjorn Andersson [this message]
2020-01-14 9:06 ` Arnaud POULIQUEN
2020-01-14 23:52 ` Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113172453.GQ738324@yoga \
--to=bjorn.andersson@linaro.org \
--cc=arnaud.pouliquen@st.com \
--cc=fabien.dessenne@st.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=ohad@wizery.com \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).