From: Michal Hocko <mhocko@kernel.org>
To: Qian Cai <cai@lca.pw>
Cc: akpm@linux-foundation.org, sergey.senozhatsky.work@gmail.com,
pmladek@suse.com, rostedt@goodmis.org, peterz@infradead.org,
david@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next v2] mm/hotplug: silence a lockdep splat with printk()
Date: Wed, 15 Jan 2020 10:24:17 +0100 [thread overview]
Message-ID: <20200115092417.GY19428@dhcp22.suse.cz> (raw)
In-Reply-To: <20200115092221.GX19428@dhcp22.suse.cz>
On Wed 15-01-20 10:22:24, Michal Hocko wrote:
[...]
> > @@ -74,9 +75,9 @@ void __dump_page(struct page *page, const char *reason)
> > page->mapping, page_to_pgoff(page),
> > compound_mapcount(page));
> > else
> > - pr_warn("page:%px refcount:%d mapcount:%d mapping:%px index:%#lx\n",
> > + pr_warn("page:%px refcount:%d mapcount:%d mapping:%px index:%#lx cma:%d\n",
> > page, page_ref_count(page), mapcount,
> > - page->mapping, page_to_pgoff(page));
> > + page->mapping, page_to_pgoff(page), page_cma);
>
> Is this correct? CMA pages cannot be comound? Btw. I would simply do
>
> pr_warn("page:%px refcount:%d mapcount:%d mapping:%px index:%#lx%s\n",
> ...., page_cmap ? "CMA": "");
Btw. if you rebased on top of http://lkml.kernel.org/r/9f884d5c-ca60-dc7b-219c-c081c755fab6@suse.cz
then the whole thing would be easier AFAICS.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-01-15 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 5:31 [PATCH -next v2] mm/hotplug: silence a lockdep splat with printk() Qian Cai
2020-01-15 9:22 ` Michal Hocko
2020-01-15 9:24 ` Michal Hocko [this message]
2020-01-15 12:35 ` Qian Cai
2020-01-15 14:46 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115092417.GY19428@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).