From: Mark Rutland <mark.rutland@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: James Clark <James.Clark@arm.com>, Will Deacon <will@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>, nd <nd@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Tan Xiaojun <tanxiaojun@huawei.com>,
Al Grant <Al.Grant@arm.com>, Namhyung Kim <namhyung@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] Return EINVAL when precise_ip perf events are requested on Arm
Date: Mon, 20 Jan 2020 15:33:56 +0000 [thread overview]
Message-ID: <20200120153355.GC43842@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20200117151658.GH14879@hirez.programming.kicks-ass.net>
On Fri, Jan 17, 2020 at 04:16:58PM +0100, Peter Zijlstra wrote:
> On Fri, Jan 17, 2020 at 03:00:37PM +0000, James Clark wrote:
> > Hi Peter,
> >
> > Do you mean something like this?
>
> Yes.
>
> > diff --git a/kernel/events/core.c b/kernel/events/core.c
> > index 43d1d4945433..f74acd085bea 100644
> > --- a/kernel/events/core.c
> > +++ b/kernel/events/core.c
> > @@ -10812,6 +10812,12 @@ perf_event_alloc(struct perf_event_attr *attr, int cpu,
> > goto err_pmu;
> > }
> >
> > + if (event->attr.precise_ip &&
> > + !(pmu->capabilities & PERF_PMU_CAP_PRECISE_IP)) {
> > + err = -EOPNOTSUPP;
> > + goto err_pmu;
> > + }
> > +
> > err = exclusive_event_init(event);
> > if (err)
> > goto err_pmu;
> >
> >
> > Or should it only be done via sysfs to not break userspace?
>
> So we've added checks like this in the past and gotten away with it. Do
> you already know of some userspace that will break due to it?
>
> An alternative approach is adding a sysctl like kernel.perf_nostrict
> which would disable this or something, that way 'old' userspace has a
> chicken bit.
Could we allocate a "strict" bit from perf_event_attr::__reserved_1, and
update drivers to expose a whitelist of fields they support?
Then the core could do something like:
if (attr->strict && !pmu_check_whitelist(pmu, attr))
return -EOPNOTSUPP;
... and we could also expose the whitelist somewhere in sysfs.
Thanks,
Mark,
next prev parent reply other threads:[~2020-01-20 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 10:58 [PATCH 0/1] Return EINVAL when precise_ip perf events are requested on Arm James Clark
2020-01-15 10:58 ` [PATCH 1/1] " James Clark
2020-01-17 12:39 ` Will Deacon
2020-01-17 13:05 ` Will Deacon
2020-01-17 13:11 ` James Clark
2020-01-17 14:01 ` Peter Zijlstra
2020-01-17 15:00 ` James Clark
2020-01-17 15:16 ` Peter Zijlstra
2020-01-20 15:33 ` Mark Rutland [this message]
2020-01-18 14:11 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120153355.GC43842@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=Al.Grant@arm.com \
--cc=James.Clark@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nd@arm.com \
--cc=peterz@infradead.org \
--cc=tanxiaojun@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).