From: Nikita Shubin <NShubin@topcon.com>
To: unlisted-recipients:; (no To-header on input)
Cc: NShubin@topcon.com, Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] remoteproc: warn on kick missing
Date: Thu, 6 Feb 2020 08:54:19 +0300 [thread overview]
Message-ID: <20200206055419.15897-1-NShubin@topcon.com> (raw)
.kick method not set in rproc_ops will result in:
8<--- cut here ---
Unable to handle kernel NULL pointer dereference
in rproc_virtio_notify, after firmware loading.
At least a warning needed on attempt to call missing method.
Signed-off-by: Nikita Shubin <NShubin@topcon.com>
---
drivers/remoteproc/remoteproc_virtio.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c
index 8c07cb2ca8ba..77a81f331e3f 100644
--- a/drivers/remoteproc/remoteproc_virtio.c
+++ b/drivers/remoteproc/remoteproc_virtio.c
@@ -32,6 +32,12 @@ static bool rproc_virtio_notify(struct virtqueue *vq)
dev_dbg(&rproc->dev, "kicking vq index: %d\n", notifyid);
+ if (unlikely(rproc->ops->kick == NULL)) {
+ WARN_ONCE(rproc->ops->kick == NULL, ".kick method not defined for %s",
+ rproc->name);
+ return false;
+ }
+
rproc->ops->kick(rproc, notifyid);
return true;
}
--
2.24.1
Confidentiality Notice: This message (including attachments) is a private communication solely for use of the intended recipient(s). If you are not the intended recipient(s) or believe you received this message in error, notify the sender immediately and then delete this message. Any other use, retention, dissemination or copying is prohibited and may be a violation of law, including the Electronic Communication Privacy Act of 1986.
next reply other threads:[~2020-02-06 5:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 5:54 Nikita Shubin [this message]
2020-02-06 10:40 ` [PATCH] remoteproc: warn on kick missing nikita.shubin
2020-02-06 20:18 ` Bjorn Andersson
2020-02-07 6:30 ` Nikita Shubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206055419.15897-1-NShubin@topcon.com \
--to=nshubin@topcon.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).