From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0F75C352A3 for ; Mon, 10 Feb 2020 13:09:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 775B22467B for ; Mon, 10 Feb 2020 13:09:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581340152; bh=ttL+jA2FXOJkyyUzpVdZiqZa99MyLN+g+DkEIquJj2E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=J24dnMebXysfvo0Z7KiEx58EEKiR5YdWnFZR2+L21K3hTXB26aBmd6apTFj245Hvh WrTjWM6dkHKzf7CgrTQ9jIRQ85v0w3v2vjLr8MOKi9iWPz/j4yMpx8rObSN2EtKfrS 9ewkENUsjaPptEHLGU3cBXtwFF3xI/9xGeVLdRlk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729707AbgBJNJL (ORCPT ); Mon, 10 Feb 2020 08:09:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:37156 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729417AbgBJMjY (ORCPT ); Mon, 10 Feb 2020 07:39:24 -0500 Received: from localhost (unknown [209.37.97.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5A3242051A; Mon, 10 Feb 2020 12:39:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581338364; bh=ttL+jA2FXOJkyyUzpVdZiqZa99MyLN+g+DkEIquJj2E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RUsXb7Na/twvtUrTIVtWaXsuFFgROqKXeW1BnL7f/RW6I/W4bhxC0UPgnLG3ktAbT xEXDSS2a36B8610mvuK721gaU4O5eINFbrdSluQLQi86clj9+K1zAm3daies89427q P4RUo8BPf9U9zTBNlt19cHm25mCDR6+/PPjHziQU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Adrian Chiris , Leon Romanovsky , "David S. Miller" Subject: [PATCH 5.5 007/367] net/core: Do not clear VF index for node/port GUIDs query Date: Mon, 10 Feb 2020 04:28:40 -0800 Message-Id: <20200210122424.498551744@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200210122423.695146547@linuxfoundation.org> References: <20200210122423.695146547@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Leon Romanovsky [ Upstream commit 9fbf082f569980ddd7cab348e0a118678db0e47e ] VF numbers were assigned to node_guid and port_guid, but cleared right before such query calls were issued. It caused to return node/port GUIDs of VF index 0 for all VFs. Fixes: 30aad41721e0 ("net/core: Add support for getting VF GUIDs") Reported-by: Adrian Chiris Signed-off-by: Leon Romanovsky Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/core/rtnetlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -1241,6 +1241,8 @@ static noinline_for_stack int rtnl_fill_ return 0; memset(&vf_vlan_info, 0, sizeof(vf_vlan_info)); + memset(&node_guid, 0, sizeof(node_guid)); + memset(&port_guid, 0, sizeof(port_guid)); vf_mac.vf = vf_vlan.vf = @@ -1289,8 +1291,6 @@ static noinline_for_stack int rtnl_fill_ sizeof(vf_trust), &vf_trust)) goto nla_put_vf_failure; - memset(&node_guid, 0, sizeof(node_guid)); - memset(&port_guid, 0, sizeof(port_guid)); if (dev->netdev_ops->ndo_get_vf_guid && !dev->netdev_ops->ndo_get_vf_guid(dev, vfs_num, &node_guid, &port_guid)) {