From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kaaira Gupta <kgupta@es.iitr.ac.in>
Cc: Julia Lawall <julia.lawall@inria.fr>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, Rob Springer <rspringer@google.com>,
Todd Poynor <toddpoynor@google.com>
Subject: Re: [PATCH v2] staging:gasket:gasket_core.c:unified quoted string split across lines in one line
Date: Wed, 12 Feb 2020 17:44:24 +0300 [thread overview]
Message-ID: <20200212144424.GI1778@kadam> (raw)
In-Reply-To: <20200212115035.GB21751@kaaira-HP-Pavilion-Notebook>
On Wed, Feb 12, 2020 at 05:20:35PM +0530, Kaaira Gupta wrote:
> When the driver tries to map a region, but the region has certain
> permissions, or when it attempts to open gasket with tgid, or when it
> realeases device node;
We don't care about any of this information...
> the logs are displayed in one line only while the
> code has the strings split in two lines which makes it difficult for
> developers to search for code based on the log messages. So, this patch
> fixes three warnings of 'quoted string split across lines' in
> gasket_core.c by merging the strings in one line.
>
> Also, I wasn't sure if I were to send a separate batch or reply with a
> v2 for this one. If former was the case than please let me know.
> Thanks for your time!
I would say:
"Kernel style says not to split string literals across mutliple lines
because it makes it difficult to grep the source for the printk. I have
changed the code accordingly. It will not affect runtime."
That's not imperative and some subsystems are more strict about "you're
not allowed to use the words 'I', 'we' or 'this patch'" in a commit
description. But in staging we are pragmatists. So long as it's clear
why you're writing the patch that's the main thing.
The other problem with this code is that some of these messages are over
80 characters long themselves which is very long for one line.
It doesn't matter if you send the v2 as a reply or not.
regards,
dan carpenter
next prev parent reply other threads:[~2020-02-12 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200211200456.GA10351@kaaira-HP-Pavilion-Notebook>
[not found] ` <alpine.DEB.2.21.2002112139550.3266@hadrien>
2020-02-12 11:50 ` [PATCH v2] staging:gasket:gasket_core.c:unified quoted string split across lines in one line Kaaira Gupta
2020-02-12 14:44 ` Dan Carpenter [this message]
2020-02-12 14:49 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212144424.GI1778@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=kgupta@es.iitr.ac.in \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).