On 2020-02-12, shuah <shuah@kernel.org> wrote:
> On 2/12/20 1:14 AM, Aleksa Sarai wrote:
> > On 2020-02-11, shuah <shuah@kernel.org> wrote:
> > > openat2:
> > > 
> > > tools/testing/selftests/openat2'
> > > gcc -Wall -O2 -g -fsanitize=address -fsanitize=undefined openat2_test.c
> > > helpers.c  -o tools/testing/selftests/openat2/openat2_test
> > > In file included from /usr/include/fcntl.h:301,
> > >                   from helpers.c:9:
> > > In function ‘openat’,
> > >      inlined from ‘touchat’ at helpers.c:49:11:
> > > /usr/include/x86_64-linux-gnu/bits/fcntl2.h:126:4: error: call to
> > > ‘__openat_missing_mode’ declared with attribute error: openat with O_CREAT
> > > or O_TMPFILE in third argument needs 4 arguments
> > >    126 |    __openat_missing_mode ();
> > >        |    ^~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Yeah, that's a brain-o -- it looks like you have a newer glibc than
> > me which gives you a warning when you don't set the mode. The fix should
> > be just the following:
> > 
> 
> Nice. Do you mind sending a proper patch, I can pull in.

Done[1].

[1]: https://lore.kernel.org/linux-kselftest/20200213072656.15611-1-cyphar@cyphar.com/

-- 
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>