From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Tachici <alexandru.tachici@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] iio: accel: adxl372: Set iio_chan BE
Date: Sat, 15 Feb 2020 15:36:53 +0000 [thread overview]
Message-ID: <20200215153653.4aee3b1d@archlinux> (raw)
In-Reply-To: <20200214092919.24351-3-alexandru.tachici@analog.com>
On Fri, 14 Feb 2020 11:29:16 +0200
Alexandru Tachici <alexandru.tachici@analog.com> wrote:
> Data stored in the iio-buffer is BE and this
> should be specified in the iio_chan_spec struct.
>
> Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
To a quick glance this looks to me like a fix we should be backporting.
Please add a fixes tag if so and I'll get this lined up to go in during
the RCs.
Thanks,
Jonathan
> ---
> drivers/iio/accel/adxl372.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c
> index bb6c2bf1a457..538e5053a946 100644
> --- a/drivers/iio/accel/adxl372.c
> +++ b/drivers/iio/accel/adxl372.c
> @@ -237,6 +237,7 @@ static const struct adxl372_axis_lookup adxl372_axis_lookup_table[] = {
> .realbits = 12, \
> .storagebits = 16, \
> .shift = 4, \
> + .endianness = IIO_BE, \
> }, \
> }
>
next prev parent reply other threads:[~2020-02-15 15:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 9:29 [PATCH 0/5] iio: accel: adxl372: add peak mode Alexandru Tachici
2020-02-14 9:29 ` [PATCH 1/5] iio: accel: adxl372: Add support for FIFO " Alexandru Tachici
2020-02-15 15:52 ` Jonathan Cameron
2020-02-14 9:29 ` [PATCH 2/5] iio: accel: adxl372: Set iio_chan BE Alexandru Tachici
2020-02-15 15:36 ` Jonathan Cameron [this message]
2020-02-14 9:29 ` [PATCH 3/5] iio: accel: adxl372: add sysfs for time registers Alexandru Tachici
2020-02-14 9:31 ` [PATCH 4/5] iio: accel: adxl372: Add sysfs for g thresholds Alexandru Tachici
2020-02-14 9:32 ` [PATCH 5/5] iio: accel: adxl372: Update sysfs docs Alexandru Tachici
2020-02-15 16:09 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200215153653.4aee3b1d@archlinux \
--to=jic23@kernel.org \
--cc=alexandru.tachici@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).