From: Guenter Roeck <linux@roeck-us.net>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Wolfram Sang <wsa@the-dreams.de>,
Martin Volf <martin.volf.42@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] watchdog: iTCO_wdt: Make ICH_RES_IO_SMI optional
Date: Tue, 25 Feb 2020 06:37:09 -0800 [thread overview]
Message-ID: <20200225143709.GA450@roeck-us.net> (raw)
In-Reply-To: <20200225123802.88984-3-mika.westerberg@linux.intel.com>
On Tue, Feb 25, 2020 at 03:38:01PM +0300, Mika Westerberg wrote:
> The iTCO_wdt driver only needs ICH_RES_IO_SMI I/O resource when either
> turn_SMI_watchdog_clear_off module parameter is set to match ->iTCO_version
> (or higher), and when legacy iTCO_vendorsupport is set. Modify the driver
> so that ICH_RES_IO_SMI is optional if the two conditions are not met.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/watchdog/iTCO_wdt.c | 22 +++++++++++++---------
> 1 file changed, 13 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
> index 156360e37714..f1692452bc25 100644
> --- a/drivers/watchdog/iTCO_wdt.c
> +++ b/drivers/watchdog/iTCO_wdt.c
> @@ -460,7 +460,7 @@ static int iTCO_wdt_probe(struct platform_device *pdev)
> return -ENODEV;
>
> p->smi_res = platform_get_resource(pdev, IORESOURCE_IO, ICH_RES_IO_SMI);
> - if (!p->smi_res)
> + if (!p->smi_res && iTCO_vendorsupport)
> return -ENODEV;
>
> p->iTCO_version = pdata->version;
> @@ -492,15 +492,19 @@ static int iTCO_wdt_probe(struct platform_device *pdev)
> /* Set the NO_REBOOT bit to prevent later reboots, just for sure */
> p->update_no_reboot_bit(p->no_reboot_priv, true);
>
> - /* The TCO logic uses the TCO_EN bit in the SMI_EN register */
> - if (!devm_request_region(dev, p->smi_res->start,
> - resource_size(p->smi_res),
> - pdev->name)) {
> - pr_err("I/O address 0x%04llx already in use, device disabled\n",
> - (u64)SMI_EN(p));
> - return -EBUSY;
> - }
> if (turn_SMI_watchdog_clear_off >= p->iTCO_version) {
> + if (!p->smi_res) {
> + pr_err("SMI I/O resource is missing\n");
> + return -EINVAL;
> + }
> + /* The TCO logic uses the TCO_EN bit in the SMI_EN register */
> + if (!devm_request_region(dev, p->smi_res->start,
> + resource_size(p->smi_res),
> + pdev->name)) {
> + pr_err("I/O address 0x%04llx already in use, device disabled\n",
> + (u64)SMI_EN(p));
> + return -EBUSY;
> + }
The request_region call is also needed if iTCO_vendorsupport is true.
Well, not strictly speaking, I guess, but then one could argue that
it isn't needed at all.
In this context - looking into the vendorsupport code, I wonder if
it is time to retire it. Separate patch, of course, but still.
Any thoughts ?
Guenter
next prev parent reply other threads:[~2020-02-25 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 12:37 [PATCH 0/3] i2c: i801: Fix iTCO_wdt resource creation if PMC is not present Mika Westerberg
2020-02-25 12:38 ` [PATCH 1/3] watchdog: iTCO_wdt: Export vendorsupport Mika Westerberg
2020-02-25 12:38 ` [PATCH 2/3] watchdog: iTCO_wdt: Make ICH_RES_IO_SMI optional Mika Westerberg
2020-02-25 14:37 ` Guenter Roeck [this message]
2020-02-25 14:42 ` Mika Westerberg
2020-02-25 12:38 ` [PATCH 3/3] i2c: i801: Do not add ICH_RES_IO_SMI if PMC device is not present Mika Westerberg
2020-02-25 14:21 ` Guenter Roeck
2020-02-25 14:40 ` Mika Westerberg
2020-02-25 14:35 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225143709.GA450@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=martin.volf.42@gmail.com \
--cc=mika.westerberg@linux.intel.com \
--cc=wim@linux-watchdog.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).