From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36ADAC3F2D0 for ; Tue, 10 Mar 2020 20:16:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E2007215A4 for ; Tue, 10 Mar 2020 20:16:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="J4M0uyN8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727556AbgCJUQd (ORCPT ); Tue, 10 Mar 2020 16:16:33 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:40647 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726545AbgCJUQc (ORCPT ); Tue, 10 Mar 2020 16:16:32 -0400 Received: by mail-pf1-f196.google.com with SMTP id l184so7014034pfl.7 for ; Tue, 10 Mar 2020 13:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DUOjVP5Gbs/kqvClABR44FE8+xg+AgbM19bKNtAY6RM=; b=J4M0uyN8yr+WE91/EnStnaXtqW7/nhowSFEP7427vQyPhmyVseK/RtuSzWChg/C9Hr zZ+zMYnkWIePFvXZqr08Bgtu6LZxyciu3wJk6FDiKEN2gAr2hr9x1d1z8YndRb7xny59 LIF8JAG0apaOV2Wrk6HcAMaxdWObISAFLKEGM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DUOjVP5Gbs/kqvClABR44FE8+xg+AgbM19bKNtAY6RM=; b=oFEgB+8VS/eIWpeWvoF2+FpNk0iMZb97jNrq4I5/ygFHbGKxPlsIUspc+6gcKUjfrC uKOilmgFji8klPNhCOcm24qG9lSYvq9We6J9i14Pw9UfMkJyOySsTmapvQPFNKA/alHI XMAL7THYzW3koBQZek5WIU37/L9tthtUFSTbazziS71t7bEwMnqxgDDmGKI8JRkAJa/j PinpKpLEk9BWxLrxtXzVnwnUqSGzGIFolOnWqqWguN/+fN2gGX7sfKENze9OsvLxdL2T PERAO77K36qysv+30yKdE/dVimXGHVuJXY3KSQ9FIZyN3hv+ulYL+IFMeByYgr2XnGYF 7SKw== X-Gm-Message-State: ANhLgQ3EyGfUI+oRBOdnJosQsDgN2b1x/A7LP6FNkcB6dho+N6f7DhJR aX8qhUhYP8/rfnxU29XpeAW29w== X-Google-Smtp-Source: ADFU+vsvmkmyViYLeWPBKmK8uPBvLdmLN608raLFS0mCOwqgEfnZb/AeMfnBRwxnwZ3Ngq2HL/ZZcg== X-Received: by 2002:a63:2882:: with SMTP id o124mr6655825pgo.390.1583871391628; Tue, 10 Mar 2020 13:16:31 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id n9sm45162722pfq.160.2020.03.10.13.16.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 13:16:30 -0700 (PDT) Date: Tue, 10 Mar 2020 13:16:29 -0700 From: Kees Cook To: "Eric W. Biederman" Cc: Christian Brauner , Bernd Edlinger , Jann Horn , Jonathan Corbet , Alexander Viro , Andrew Morton , Alexey Dobriyan , Thomas Gleixner , Oleg Nesterov , Frederic Weisbecker , Andrei Vagin , Ingo Molnar , "Peter Zijlstra (Intel)" , Yuyang Du , David Hildenbrand , Sebastian Andrzej Siewior , Anshuman Khandual , David Howells , James Morris , Greg Kroah-Hartman , Shakeel Butt , Jason Gunthorpe , Christian Kellner , Andrea Arcangeli , Aleksa Sarai , "Dmitry V. Levin" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "stable@vger.kernel.org" , "linux-api@vger.kernel.org" Subject: Re: [PATCH v2 3/5] exec: Move cleanup of posix timers on exec out of de_thread Message-ID: <202003101313.CF8CBDC582@keescook> References: <87r1y8dqqz.fsf@x220.int.ebiederm.org> <87tv32cxmf.fsf_-_@x220.int.ebiederm.org> <87v9ne5y4y.fsf_-_@x220.int.ebiederm.org> <87eeu25y14.fsf_-_@x220.int.ebiederm.org> <20200309195909.h2lv5uawce5wgryx@wittgenstein> <877dztz415.fsf@x220.int.ebiederm.org> <20200309201729.yk5sd26v4bz4gtou@wittgenstein> <87k13txnig.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k13txnig.fsf@x220.int.ebiederm.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2020 at 03:48:55PM -0500, Eric W. Biederman wrote: > And I completely agree that we should at least rename tsk to me. > Just for clarity. I think it wouldn't hurt to add comments to spell it out explicitly in each of the tsk->me functions, something like: /* * The "me" task_struct argument here must only ever refer to "current", * but it gets passed in to avoid re-calculating "current" in each helper. */ I've found that the exec code in its entirety would be better off with more comments. :) Usually that's the bulk of what I find myself adding when I make changes in this area. ;) -Kees -- Kees Cook