linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: afzal mohammed <afzal.mohd.ma@gmail.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Ralf Baechle <ralf@linux-mips.org>,
	Paul Burton <paulburton@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	bcm-kernel-feedback-list@broadcom.com,
	"Maciej W. Rozycki" <macro@linux-mips.org>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Keguang Zhang <keguang.zhang@gmail.com>,
	Huacai Chen <chenhc@lemote.com>, John Crispin <john@phrozen.org>
Subject: Re: [PATCH v4] MIPS: Replace setup_irq() by request_irq()
Date: Wed, 11 Mar 2020 11:42:17 +0100	[thread overview]
Message-ID: <20200311104217.GA10615@alpha.franken.de> (raw)
In-Reply-To: <20200311090308.GA5060@afzalpc>

On Wed, Mar 11, 2020 at 02:33:08PM +0530, afzal mohammed wrote:
> diff --git a/arch/mips/kernel/cevt-r4k.c b/arch/mips/kernel/cevt-r4k.c
> index 64e917dfe6b2..d24e4f2985c3 100644
> --- a/arch/mips/kernel/cevt-r4k.c
> +++ b/arch/mips/kernel/cevt-r4k.c
> @@ -252,7 +252,7 @@ unsigned int __weak get_c0_compare_int(void)
>  
>  int r4k_clockevent_init(void)
>  {
> -	unsigned long flags = IRQF_PERCPU | IRQF_TIMER | IRQF_SHARED;
> +	unsigned long flags = IRQF_PERCPU | IRQF_TIMER;
>  	unsigned int cpu = smp_processor_id();
>  	struct clock_event_device *cd;
>  	unsigned int irq, min_delta;

I don't see why this should help. In my tree only sgi-ip30 removes
IRQF_SHARED from flags, but then it uses setup_percpu_irq().
What do I miss ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

  reply	other threads:[~2020-03-11 10:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04  0:55 [PATCH v3] MIPS: Replace setup_irq() by request_irq() afzal mohammed
2020-03-04 20:31 ` Thomas Bogendoerfer
2020-03-05 11:57   ` [PATCH v4] " afzal mohammed
2020-03-06 12:47     ` Thomas Bogendoerfer
2020-03-11  5:31     ` Nathan Chancellor
2020-03-11  7:56       ` afzal mohammed
2020-03-11  9:03       ` afzal mohammed
2020-03-11 10:42         ` Thomas Bogendoerfer [this message]
2020-03-11 13:12           ` afzal mohammed
2020-03-11 16:03             ` Thomas Bogendoerfer
2020-03-11 16:32               ` afzal mohammed
2020-03-13 12:11                 ` afzal mohammed
2020-03-14  8:13                   ` [PATCH v2] MIPS: pass non-NULL dev_id on shared request_irq() afzal mohammed
2020-03-14 17:19                     ` Guenter Roeck
2020-03-15  7:11                     ` Nathan Chancellor
2020-03-16 15:32                     ` Thomas Bogendoerfer
2020-03-14  6:55                 ` [PATCH v4] MIPS: Replace setup_irq() by request_irq() afzal mohammed
2020-03-11 15:27           ` [PATCH] MIPS: pass non-NULL dev_id on shared request_irq() afzal mohammed
2020-03-11 16:06           ` afzal mohammed
2020-03-13 16:47     ` [PATCH v4] MIPS: Replace setup_irq() by request_irq() Guenter Roeck
2020-03-14  1:07       ` afzal mohammed
     [not found]         ` <0b41aa60-9869-ab62-4c8e-cbf7c62cdb7e@loongson.cn>
2020-03-14  6:49           ` afzal mohammed
2020-03-14 10:28         ` Guenter Roeck
2020-03-14 11:42           ` afzal mohammed
2020-03-05 12:29   ` [PATCH v3] " afzal mohammed
2020-03-05 12:42     ` afzal mohammed
2020-03-04 20:38 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200311104217.GA10615@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=afzal.mohd.ma@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=chenhc@lemote.com \
    --cc=f.fainelli@gmail.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=john@phrozen.org \
    --cc=keguang.zhang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=natechancellor@gmail.com \
    --cc=paulburton@kernel.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).