From: Kees Cook <keescook@chromium.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Arvind Sankar <nivedita@alum.mit.edu>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Thomas Lendacky <Thomas.Lendacky@amd.com>,
Mauro Rossi <issor.oruam@gmail.com>, Michael Matz <matz@suse.de>
Subject: Re: [PATCH] Documentation/changes: Raise minimum supported binutils version to 2.23
Date: Mon, 16 Mar 2020 13:54:35 -0700 [thread overview]
Message-ID: <202003161354.538479F16@keescook> (raw)
In-Reply-To: <20200316160259.GN26126@zn.tnic>
On Mon, Mar 16, 2020 at 05:02:59PM +0100, Borislav Petkov wrote:
> Long overdue patch, see below.
>
> Plan is to queue it after 5.7-rc1.
>
> ---
> From: Borislav Petkov <bp@suse.de>
> Date: Mon, 16 Mar 2020 16:28:36 +0100
> Subject: [PATCH] Documentation/changes: Raise minimum supported binutilsa version to 2.23
>
> The currently minimum-supported binutils version 2.21 has the problem of
> promoting symbols which are defined outside of a section into absolute.
> According to Arvind:
>
> binutils-2.21 and -2.22. An x86-64 defconfig will fail with
> Invalid absolute R_X86_64_32S relocation: _etext
> and after fixing that one, with
> Invalid absolute R_X86_64_32S relocation: __end_of_kernel_reserve
>
> Those two versions of binutils have a bug when it comes to handling
> symbols defined outside of a section and binutils 2.23 has the proper
> fix, see: https://sourceware.org/legacy-ml/binutils/2012-06/msg00155.html
>
> Therefore, up to the fixed version directly, skipping the broken ones.
>
> Currently shipping distros already have the fixed binutils version so
> there should be no breakage resulting from this.
>
> For more details about the whole thing, see the thread in Link.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
> Link: https://lkml.kernel.org/r/20200110202349.1881840-1-nivedita@alum.mit.edu
> ---
> Documentation/process/changes.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/process/changes.rst b/Documentation/process/changes.rst
> index e47863575917..7a842655142c 100644
> --- a/Documentation/process/changes.rst
> +++ b/Documentation/process/changes.rst
> @@ -31,7 +31,7 @@ you probably needn't concern yourself with pcmciautils.
> ====================== =============== ========================================
> GNU C 4.6 gcc --version
> GNU make 3.81 make --version
> -binutils 2.21 ld -v
> +binutils 2.23 ld -v
> flex 2.5.35 flex --version
> bison 2.0 bison --version
> util-linux 2.10o fdformat --version
> --
> 2.21.0
>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
--
Kees Cook
next prev parent reply other threads:[~2020-03-16 20:54 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 20:23 [PATCH] x86/tools/relocs: Add _etext and __end_of_kernel_reserve to S_REL Arvind Sankar
2020-01-10 20:38 ` Borislav Petkov
2020-01-10 20:50 ` Arvind Sankar
2020-01-10 21:50 ` [PATCH v2] " Arvind Sankar
2020-01-10 21:52 ` Arvind Sankar
2020-01-11 13:02 ` [PATCH] " Borislav Petkov
2020-01-11 17:20 ` Arvind Sankar
2020-01-11 17:32 ` Arvind Sankar
2020-01-13 13:43 ` Borislav Petkov
2020-01-13 16:13 ` Arvind Sankar
2020-01-13 16:38 ` Borislav Petkov
2020-01-13 17:59 ` Arvind Sankar
2020-01-13 18:08 ` Borislav Petkov
2020-01-14 4:17 ` Arvind Sankar
2020-01-14 11:25 ` Borislav Petkov
2020-01-14 16:32 ` Arvind Sankar
2020-01-14 4:08 ` Arvind Sankar
2020-01-13 19:53 ` [PATCH v3] x86/vmlinux: Fix vmlinux.lds.S with pre-2.23 binutils Arvind Sankar
2020-01-13 21:46 ` Tom Lendacky
2020-01-13 23:06 ` Arvind Sankar
2020-01-14 1:53 ` Kees Cook
2020-01-14 1:57 ` H. Peter Anvin
2020-01-14 2:20 ` Kees Cook
2020-01-14 3:58 ` Arvind Sankar
2020-01-14 5:05 ` hpa
2020-01-14 16:51 ` Borislav Petkov
2020-01-14 21:50 ` hpa
2020-01-15 0:21 ` Arvind Sankar
2020-01-15 12:24 ` Borislav Petkov
2020-03-16 16:02 ` [PATCH] Documentation/changes: Raise minimum supported binutils version to 2.23 Borislav Petkov
2020-03-16 20:54 ` Kees Cook [this message]
2020-03-23 20:44 ` Jason A. Donenfeld
2020-03-23 20:51 ` Kees Cook
2020-03-23 21:11 ` Jason A. Donenfeld
2020-03-25 17:33 ` David Laight
2020-03-24 9:02 ` Masahiro Yamada
2020-03-24 9:12 ` Masahiro Yamada
2020-03-24 15:38 ` Arvind Sankar
2020-03-24 17:31 ` Masahiro Yamada
2020-03-24 21:36 ` Arvind Sankar
2020-03-24 9:14 ` Borislav Petkov
2020-03-24 9:40 ` Masahiro Yamada
2020-03-24 12:00 ` Borislav Petkov
2020-03-24 16:22 ` Jason A. Donenfeld
2020-03-24 16:28 ` Borislav Petkov
2020-03-24 16:37 ` Linus Torvalds
2020-03-24 16:48 ` Borislav Petkov
2020-03-24 21:42 ` Arvind Sankar
2020-03-24 22:01 ` Arvind Sankar
2020-03-24 22:14 ` Linus Torvalds
2020-03-24 23:49 ` Arvind Sankar
2020-03-24 17:53 ` Kees Cook
2020-03-23 20:50 ` [PATCH] Documentation/changes: Raise minimum supported binutilsa " Nick Desaulniers
2020-01-13 23:38 ` [PATCH] x86/tools/relocs: Add _etext and __end_of_kernel_reserve to S_REL Arvind Sankar
2020-01-10 20:56 ` Kees Cook
[not found] ` <CAEQFVGa4fksPRtiLtBckSgbJY_JSHr07hoy5+5w-pAYym16YVg@mail.gmail.com>
2020-01-11 19:40 ` Fwd: " Mauro Rossi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202003161354.538479F16@keescook \
--to=keescook@chromium.org \
--cc=Thomas.Lendacky@amd.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=issor.oruam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matz@suse.de \
--cc=mingo@redhat.com \
--cc=nivedita@alum.mit.edu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).