From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-mediatek@lists.infradead.org,
virtualization@lists.linux-foundation.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH 12/15] iommu/mediatek: Use accessor functions for iommu private data
Date: Mon, 16 Mar 2020 16:51:16 +0100 [thread overview]
Message-ID: <20200316155116.GL304669@myrica> (raw)
In-Reply-To: <20200310091229.29830-13-joro@8bytes.org>
On Tue, Mar 10, 2020 at 10:12:26AM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> Make use of dev_iommu_priv_set/get() functions.
>
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> ---
> drivers/iommu/mtk_iommu.c | 13 ++++++-------
> drivers/iommu/mtk_iommu_v1.c | 14 +++++++-------
> 2 files changed, 13 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index 95945f467c03..5f4d6df59cf6 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -358,8 +358,8 @@ static void mtk_iommu_domain_free(struct iommu_domain *domain)
> static int mtk_iommu_attach_device(struct iommu_domain *domain,
> struct device *dev)
> {
> + struct mtk_iommu_data *data = dev_iommu_priv_get(dev);
> struct mtk_iommu_domain *dom = to_mtk_domain(domain);
> - struct mtk_iommu_data *data = dev_iommu_fwspec_get(dev)->iommu_priv;
>
> if (!data)
> return -ENODEV;
> @@ -378,7 +378,7 @@ static int mtk_iommu_attach_device(struct iommu_domain *domain,
> static void mtk_iommu_detach_device(struct iommu_domain *domain,
> struct device *dev)
> {
> - struct mtk_iommu_data *data = dev_iommu_fwspec_get(dev)->iommu_priv;
> + struct mtk_iommu_data *data = dev_iommu_priv_get(dev);
>
> if (!data)
> return;
> @@ -450,7 +450,7 @@ static int mtk_iommu_add_device(struct device *dev)
> if (!fwspec || fwspec->ops != &mtk_iommu_ops)
> return -ENODEV; /* Not a iommu client device */
>
> - data = fwspec->iommu_priv;
> + data = dev_iommu_priv_get(dev);
> iommu_device_link(&data->iommu, dev);
>
> group = iommu_group_get_for_dev(dev);
> @@ -469,7 +469,7 @@ static void mtk_iommu_remove_device(struct device *dev)
> if (!fwspec || fwspec->ops != &mtk_iommu_ops)
> return;
>
> - data = fwspec->iommu_priv;
> + data = dev_iommu_priv_get(dev);
> iommu_device_unlink(&data->iommu, dev);
>
> iommu_group_remove_device(dev);
> @@ -496,7 +496,6 @@ static struct iommu_group *mtk_iommu_device_group(struct device *dev)
>
> static int mtk_iommu_of_xlate(struct device *dev, struct of_phandle_args *args)
> {
> - struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);
> struct platform_device *m4updev;
>
> if (args->args_count != 1) {
> @@ -505,13 +504,13 @@ static int mtk_iommu_of_xlate(struct device *dev, struct of_phandle_args *args)
> return -EINVAL;
> }
>
> - if (!fwspec->iommu_priv) {
> + if (!dev_iommu_priv_get(dev)) {
> /* Get the m4u device */
> m4updev = of_find_device_by_node(args->np);
> if (WARN_ON(!m4updev))
> return -EINVAL;
>
> - fwspec->iommu_priv = platform_get_drvdata(m4updev);
> + dev_iommu_priv_set(dev, platform_get_drvdata(m4updev));
> }
>
> return iommu_fwspec_add_ids(dev, args->args, 1);
> diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c
> index e93b94ecac45..9930ac7413cc 100644
> --- a/drivers/iommu/mtk_iommu_v1.c
> +++ b/drivers/iommu/mtk_iommu_v1.c
> @@ -263,8 +263,8 @@ static void mtk_iommu_domain_free(struct iommu_domain *domain)
> static int mtk_iommu_attach_device(struct iommu_domain *domain,
> struct device *dev)
> {
> + struct mtk_iommu_data *data = dev_iommu_priv_get(dev);
> struct mtk_iommu_domain *dom = to_mtk_domain(domain);
> - struct mtk_iommu_data *data = dev_iommu_fwspec_get(dev)->iommu_priv;
> int ret;
>
> if (!data)
> @@ -286,7 +286,7 @@ static int mtk_iommu_attach_device(struct iommu_domain *domain,
> static void mtk_iommu_detach_device(struct iommu_domain *domain,
> struct device *dev)
> {
> - struct mtk_iommu_data *data = dev_iommu_fwspec_get(dev)->iommu_priv;
> + struct mtk_iommu_data *data = dev_iommu_priv_get(dev);
>
> if (!data)
> return;
> @@ -387,20 +387,20 @@ static int mtk_iommu_create_mapping(struct device *dev,
> return -EINVAL;
> }
>
> - if (!fwspec->iommu_priv) {
> + if (!dev_iommu_priv_get(dev)) {
> /* Get the m4u device */
> m4updev = of_find_device_by_node(args->np);
> if (WARN_ON(!m4updev))
> return -EINVAL;
>
> - fwspec->iommu_priv = platform_get_drvdata(m4updev);
> + dev_iommu_priv_set(dev, platform_get_drvdata(m4updev));
> }
>
> ret = iommu_fwspec_add_ids(dev, args->args, 1);
> if (ret)
> return ret;
>
> - data = fwspec->iommu_priv;
> + data = dev_iommu_priv_get(dev);
> m4udev = data->dev;
> mtk_mapping = m4udev->archdata.iommu;
> if (!mtk_mapping) {
> @@ -459,7 +459,7 @@ static int mtk_iommu_add_device(struct device *dev)
> if (err)
> return err;
>
> - data = fwspec->iommu_priv;
> + data = dev_iommu_priv_get(dev)
> mtk_mapping = data->dev->archdata.iommu;
> err = arm_iommu_attach_device(dev, mtk_mapping);
> if (err) {
> @@ -478,7 +478,7 @@ static void mtk_iommu_remove_device(struct device *dev)
> if (!fwspec || fwspec->ops != &mtk_iommu_ops)
> return;
>
> - data = fwspec->iommu_priv;
> + data = dev_iommu_priv_get(dev)
> iommu_device_unlink(&data->iommu, dev);
>
> iommu_group_remove_device(dev);
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-03-16 15:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 9:12 [PATCH 00/15 v2] iommu: Move iommu_fwspec out of 'struct device' Joerg Roedel
2020-03-10 9:12 ` [PATCH 01/15] iommu: Define dev_iommu_fwspec_get() for !CONFIG_IOMMU_API Joerg Roedel
2020-03-16 15:39 ` Jean-Philippe Brucker
2020-03-10 9:12 ` [PATCH 02/15] ACPI/IORT: Remove direct access of dev->iommu_fwspec Joerg Roedel
2020-03-16 15:40 ` Jean-Philippe Brucker
2020-03-10 9:12 ` [PATCH 03/15] drm/msm/mdp5: " Joerg Roedel
2020-03-16 15:42 ` Jean-Philippe Brucker
2020-03-10 9:12 ` [PATCH 04/15] iommu/tegra-gart: " Joerg Roedel
2020-03-16 15:42 ` Jean-Philippe Brucker
2020-03-10 9:12 ` [PATCH 05/15] iommu: Rename struct iommu_param to dev_iommu Joerg Roedel
2020-03-16 15:45 ` Jean-Philippe Brucker
2020-03-10 9:12 ` [PATCH 06/15] iommu: Move iommu_fwspec to struct dev_iommu Joerg Roedel
2020-03-16 15:46 ` Jean-Philippe Brucker
2020-03-10 9:12 ` [PATCH 07/15] iommu/arm-smmu: Fix uninitilized variable warning Joerg Roedel
2020-03-16 15:47 ` Jean-Philippe Brucker
2020-03-10 9:12 ` [PATCH 08/15] iommu: Introduce accessors for iommu private data Joerg Roedel
2020-03-16 15:47 ` Jean-Philippe Brucker
2020-03-10 9:12 ` [PATCH 09/15] iommu/arm-smmu-v3: Use accessor functions " Joerg Roedel
2020-03-16 15:49 ` Jean-Philippe Brucker
2020-03-10 9:12 ` [PATCH 10/15] iommu/arm-smmu: " Joerg Roedel
2020-03-16 17:55 ` Jean-Philippe Brucker
2020-03-10 9:12 ` [PATCH 11/15] iommu/renesas: " Joerg Roedel
2020-03-16 15:50 ` Jean-Philippe Brucker
2020-03-10 9:12 ` [PATCH 12/15] iommu/mediatek: " Joerg Roedel
2020-03-16 15:51 ` Jean-Philippe Brucker [this message]
2020-03-10 9:12 ` [PATCH 13/15] iommu/qcom: " Joerg Roedel
2020-03-16 15:52 ` Jean-Philippe Brucker
2020-03-19 13:11 ` Joerg Roedel
2020-03-10 9:12 ` [PATCH 14/15] iommu/virtio: " Joerg Roedel
2020-03-16 15:56 ` Jean-Philippe Brucker
2020-03-10 9:12 ` [PATCH 15/15] iommu: Move fwspec->iommu_priv to struct dev_iommu Joerg Roedel
2020-03-16 15:57 ` Jean-Philippe Brucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316155116.GL304669@myrica \
--to=jean-philippe@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=guohanjun@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=sean@poorly.run \
--cc=sudeep.holla@arm.com \
--cc=thierry.reding@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).