From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Shreyas Joshi <Shreyas.Joshi@biamp.com>,
"pmladek@suse.com" <pmladek@suse.com>,
"sergey.senozhatsky@gmail.com" <sergey.senozhatsky@gmail.com>,
"shreyasjoshi15@gmail.com" <shreyasjoshi15@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] printk: handle blank console arguments passed in.
Date: Tue, 17 Mar 2020 11:01:44 +0900 [thread overview]
Message-ID: <20200317020144.GB219881@google.com> (raw)
In-Reply-To: <20200316213900.6b1eb594@oasis.local.home>
On (20/03/16 21:39), Steven Rostedt wrote:
[..]
> >
> > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index ad4606234545..e9ad730991e0 100644
> > --- a/kernel/printk/printk.c
> > +++ b/kernel/printk/printk.c
> > @@ -2165,7 +2165,10 @@ static int __init console_setup(char *str)
> > char buf[sizeof(console_cmdline[0].name) + 4]; /* 4 for "ttyS" */
> > char *s, *options, *brl_options = NULL;
> > int idx;
> > -
> > + if (str[0] == 0) {
> > + console_loglevel = 0;
> > + return 1;
>
> Hmm, I wonder if this should produce a warning :-/
Hmm. Maybe the warning can seat in __setup() handling?
There are 300+ places that theoretically can receive blank boot param
$ git grep "__setup(\".*=\"" | wc -l
307
I'd assume that not all of those can handle blank params. At the same
time, do we have cases when passing blank boot params is OK? E.g.
"... root=/dev/sda1 foo= bar= ..."
-ss
next prev parent reply other threads:[~2020-03-17 2:01 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 5:29 [PATCH] printk: handle blank console arguments passed in Shreyas Joshi
2020-03-17 1:34 ` Shreyas Joshi
2020-03-17 1:39 ` Steven Rostedt
2020-03-17 2:01 ` Sergey Senozhatsky [this message]
2020-03-17 2:17 ` Shreyas Joshi
2020-03-17 8:22 ` Sergey Senozhatsky
2020-05-22 6:46 ` Shreyas Joshi
2020-05-22 6:53 ` Shreyas Joshi
2020-05-22 10:00 ` Petr Mladek
2020-10-06 2:59 ` Sergey Senozhatsky
2020-10-06 3:35 ` Guenter Roeck
2020-10-06 5:08 ` Greg Kroah-Hartman
2020-10-06 11:17 ` Guenter Roeck
2020-10-06 6:59 ` Sergey Senozhatsky
2020-10-06 9:54 ` Petr Mladek
2020-10-06 13:33 ` Sergey Senozhatsky
2020-10-06 14:22 ` Guenter Roeck
2020-10-06 16:08 ` Sergey Senozhatsky
2020-10-06 9:52 ` Petr Mladek
2020-10-06 10:45 ` Guenter Roeck
2020-10-06 13:43 ` Petr Mladek
2020-10-06 16:35 ` Petr Mladek
2020-10-06 17:15 ` Sergey Senozhatsky
2020-10-07 7:28 ` Petr Mladek
2020-10-07 12:30 ` Sergey Senozhatsky
2020-10-07 14:39 ` Sergey Senozhatsky
2020-10-07 15:57 ` Guenter Roeck
2020-10-07 16:29 ` Sergey Senozhatsky
2020-10-08 5:52 ` Sergey Senozhatsky
2020-10-08 9:01 ` Petr Mladek
2020-10-08 10:56 ` Sergey Senozhatsky
2020-10-08 12:05 ` Sergey Senozhatsky
2020-10-22 11:38 ` Petr Mladek
2020-10-22 13:32 ` Sergey Senozhatsky
2020-10-08 8:50 ` Petr Mladek
2020-10-08 12:20 ` Sergey Senozhatsky
2020-10-08 12:37 ` Sergey Senozhatsky
2020-05-15 15:24 ` Petr Mladek
2020-05-20 11:50 ` Sergey Senozhatsky
2020-05-22 6:40 ` Shreyas Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317020144.GB219881@google.com \
--to=sergey.senozhatsky.work@gmail.com \
--cc=Shreyas.Joshi@biamp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=shreyasjoshi15@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).