From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URG_BIZ,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7BCBC10DCE for ; Tue, 24 Mar 2020 22:01:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A4BA2077D for ; Tue, 24 Mar 2020 22:01:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bGI5dSTl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728301AbgCXWBv (ORCPT ); Tue, 24 Mar 2020 18:01:51 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:34386 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727040AbgCXWBv (ORCPT ); Tue, 24 Mar 2020 18:01:51 -0400 Received: by mail-qt1-f193.google.com with SMTP id 10so431517qtp.1 for ; Tue, 24 Mar 2020 15:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6LQiM/oiHlOdvbe9Zjo6nFmhV//jY0W79rboX0wJ6ks=; b=bGI5dSTlEP4McaHIhW2swe7VBaWjxLJjEb9R29+Zh671fr4Y/q0xHT5EEHlNKJ9JEw m62jvP3wvny29rhGRwWwQHhXDj0Y5bejOCNZ0uegFTspOcxKwdmbBSBEsOPxKrBg6dG3 j/+yvQ40FKiGlXOSgMQJvZG9i8dbcKK5WpXOncu9simEL/E3d9ZbJhuewri3bpc8ZFT+ uUuuhn1mC3clzZun7CSqCSA/5Key3bKoTE9k8aUVP2GZUFyoJPKxHPH8QNen5aCJOyNO WZt0YCEnzeYykiSELrYZNJzrj2+iTyYPX7cTt3/7pT4y2rST3Gbbr6BU1wWisNvAsSJE 7YpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:date:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=6LQiM/oiHlOdvbe9Zjo6nFmhV//jY0W79rboX0wJ6ks=; b=CLPzESBxAZwst0espyEpOUEh45G2XU47LHLmZmcOu70r/pOUoqVoU6boYrDnIs/NNS RxFswyiMR4/TYJdZDAnIAkE0j18Aptsz1Vc5NEfEpIVPc/LGBHjOIJk8OOiW8QxipYMn NTWc1m5ITabwX86zCf65DFkksNgeKEJ5hWB0INyxTPoNtNdhfWm+lCoaMS5BmlEU/oD+ 5DGvsyJ95IpC3DU9m4KdbOKSBv19d1jpGR1AhkFIyuKxfmczFbdljFL8rY2OugmXEbUk cHg5g1Al1klWBGHqMZbf5b4z75ke5uoVMDaeOM9T5qCk9Vi4NZD0pXLL/egGhoH4uTxb 3YHQ== X-Gm-Message-State: ANhLgQ36gJOTZwEzORvCPRXs1mJmhGhS1QsTXnaXOpJUpeXF0K3zjN0G x7nAGOE6BcIxC88JoKguLq0= X-Google-Smtp-Source: ADFU+vvSu//9WABHZWRBUHb0iK5A96tEirBjKnTPu73adm8gR92EBBoeASXuuz6LIsZiBzF8hWM3aw== X-Received: by 2002:ac8:110a:: with SMTP id c10mr28393372qtj.365.1585087309761; Tue, 24 Mar 2020 15:01:49 -0700 (PDT) Received: from rani.riverdale.lan ([2001:470:1f07:5f3::b55f]) by smtp.gmail.com with ESMTPSA id u40sm15584424qtc.62.2020.03.24.15.01.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 15:01:49 -0700 (PDT) From: Arvind Sankar X-Google-Original-From: Arvind Sankar Date: Tue, 24 Mar 2020 18:01:47 -0400 To: Arvind Sankar Cc: Borislav Petkov , Linus Torvalds , "Jason A. Donenfeld" , Masahiro Yamada , Kees Cook , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , X86 ML , Linux Kernel Mailing List , Thomas Lendacky , Mauro Rossi , Michael Matz Subject: Re: [PATCH] Documentation/changes: Raise minimum supported binutils version to 2.23 Message-ID: <20200324220147.GA3253486@rani.riverdale.lan> References: <20200316160259.GN26126@zn.tnic> <20200323204454.GA2611336@zx2c4.com> <202003231350.7D35351@keescook> <20200324091437.GB22931@zn.tnic> <20200324162843.GE22931@zn.tnic> <20200324164812.GG22931@zn.tnic> <20200324214204.GB3220053@rani.riverdale.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200324214204.GB3220053@rani.riverdale.lan> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2020 at 05:42:05PM -0400, Arvind Sankar wrote: > On Tue, Mar 24, 2020 at 05:48:12PM +0100, Borislav Petkov wrote: > > On Tue, Mar 24, 2020 at 09:37:13AM -0700, Linus Torvalds wrote: > > > I think it's ok. It's not going to cause any _subtle_ failures, it's > > > going to cause very clear "oh, now it doesn't build" errors. > > > > > > No? > > > > > > And binutils 2.23 is what, 7+ years old by now and apparently had > > > known failure cases too. > > > > > > But if there are silent and subtle failures, that might be a reason to > > > be careful. Are there? > > > > Well, not that I know of and that's why I'm being overly cautious. Maybe > > too cautious but a lot of hectic testing of last minute fixes in the > > past have taught me to take my time. > > > > And since it doesn't really matter when the patch goes in - there's > > always the next merge window - I would prefer to take our time and have > > it simmer in -next for max period. > > > > So yeah, 2.23 has been tested for a long time now and it is very likely > > that nothing would happen and if you think it's ok, then sure. Then if > > you happen to see urgent pull requests with build or some other fixes, > > at least you'll be prepared. :-) > > > > This is just a documentation patch right? Nothing actually changes with > the build. The only possible thing that we would potentially have to > deal with is > > (1) people noticing the doc change and complaining that they > still need to use binutils-2.21 for some reason -- but they can't > currently build an x86 kernel without patches anyway, so... The __end_of_kernel_reserve symbol that breaks with the 2.21-2.22 binutils was added in v5.3, so we've already gone 3 kernel versions without complaints. > > (2) people noticing the doc change and suggesting moving to 2.26 or some > later version instead of 2.23.