From: "Paul E. McKenney" <paulmck@kernel.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: linux-kernel@vger.kernel.org, julia.lawall@lip6.fr,
boqun.feng@gmail.com, Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
"open list:READ-COPY UPDATE (RCU)" <rcu@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] rcu: Replace 1 by true
Date: Mon, 30 Mar 2020 14:16:04 -0700 [thread overview]
Message-ID: <20200330211604.GA6655@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20200330012450.312155-3-jbi.octave@gmail.com>
On Mon, Mar 30, 2020 at 02:24:48AM +0100, Jules Irenge wrote:
> Coccinelle reports a warning at use_softirq declaration
>
> WARNING: Assignment of 0/1 to bool variable
>
> The root cause is
> use_softirq a variable of bool type is initialised with the integer 1
> Replacing 1 with value true solve the issue.
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Queued for review and testing, thank you!
Thanx, Paul
> ---
> kernel/rcu/tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index d91c9156fab2..c2ffea31eae8 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -100,7 +100,7 @@ static struct rcu_state rcu_state = {
> static bool dump_tree;
> module_param(dump_tree, bool, 0444);
> /* By default, use RCU_SOFTIRQ instead of rcuc kthreads. */
> -static bool use_softirq = 1;
> +static bool use_softirq = true;
> module_param(use_softirq, bool, 0444);
> /* Control rcu_node-tree auto-balancing at boot time. */
> static bool rcu_fanout_exact;
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-03-30 21:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/4>
2020-03-30 1:24 ` [PATCH v2 0/4] Coccinelle cleanups Jules Irenge
2020-03-30 1:24 ` [PATCH v2 1/4] cpu: Remove Comparison to bool Jules Irenge
2020-03-30 1:24 ` [PATCH v2 2/4] rcu: Replace 1 by true Jules Irenge
2020-03-30 21:16 ` Paul E. McKenney [this message]
2020-03-30 1:24 ` [PATCH v2 3/4] genirq: " Jules Irenge
2020-03-30 1:24 ` [PATCH v2 4/4] locking/rtmutex: Remove Comparison to bool Jules Irenge
2020-03-30 11:21 ` Peter Zijlstra
2020-04-03 16:17 ` Jules Irenge
2020-08-01 18:45 ` [PATCH 0/4] Checkpatch tool errors clean up Jules Irenge
2020-08-01 18:46 ` [PATCH 1/4] acct: Add required space between variable and operator Jules Irenge
2020-08-01 18:46 ` [PATCH 2/4] audit: uninitialize global variable audit_sig_sid Jules Irenge
2020-08-01 18:55 ` Joe Perches
2020-08-01 20:26 ` Paul Moore
2020-08-02 14:32 ` Jules Irenge
2020-08-01 18:46 ` [PATCH 3/4] audit: uninitialize static variables Jules Irenge
2020-08-01 20:21 ` Paul Moore
2020-08-01 18:46 ` [PATCH 4/4] context_tracking: " Jules Irenge
2020-08-03 9:37 ` peterz
2020-08-03 10:27 ` Jules Irenge
2020-08-01 19:07 ` [PATCH 0/4] Checkpatch tool errors clean up Joe Perches
2020-08-02 14:54 ` Jules Irenge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330211604.GA6655@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=jbi.octave@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).