Hi all, After merging the gpio tree, today's linux-next build (x86_64 allmodconfig) failed like this: ERROR: modpost: "of_pinctrl_get" [drivers/gpio/gpio-tegra186.ko] undefined! Caused by commit b64d6c9a6a05 ("gpio: tegra186: Add support for pin ranges") and not fixed by commit e45ee71ae101 ("pinctrl: Define of_pinctrl_get() dummy for !PINCTRL") CONFIG_OF=y CONFIG_PINCTRL=y CONFIG_GPIO_TEGRA186=m I applied this patch: From: Stephen Rothwell Date: Wed, 1 Apr 2020 15:14:32 +1100 Subject: [PATCH] gpio: export of_pinctrl_get to modules Signed-off-by: Stephen Rothwell --- drivers/pinctrl/devicetree.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/devicetree.c b/drivers/pinctrl/devicetree.c index 1ed20ac2243f..c6fe7d64c913 100644 --- a/drivers/pinctrl/devicetree.c +++ b/drivers/pinctrl/devicetree.c @@ -103,6 +103,7 @@ struct pinctrl_dev *of_pinctrl_get(struct device_node *np) { return get_pinctrl_dev_from_of_node(np); } +EXPORT_SYMBOL_GPL(of_pinctrl_get); static int dt_to_map_one_config(struct pinctrl *p, struct pinctrl_dev *hog_pctldev, -- 2.25.0 -- Cheers, Stephen Rothwell