From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
kbuild test robot <lkp@intel.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: [PATCH v2 06/10] mmc: meson-mx-sdio: Depend on OF_ADDRESS and not just OF
Date: Wed, 8 Apr 2020 23:44:12 -0700 [thread overview]
Message-ID: <20200409064416.83340-7-sboyd@kernel.org> (raw)
In-Reply-To: <20200409064416.83340-1-sboyd@kernel.org>
Making COMMON_CLK a visible option causes the sparc allyesconfig to fail
to build like so:
sparc64-linux-ld: drivers/mmc/host/meson-mx-sdio.o: in function `meson_mx_mmc_remove':
meson-mx-sdio.c:(.text+0x70): undefined reference to `of_platform_device_destroy'
sparc64-linux-ld: drivers/mmc/host/meson-mx-sdio.o: in function `meson_mx_mmc_probe':
meson-mx-sdio.c:(.text+0x9e4): undefined reference to `of_platform_device_create'
sparc64-linux-ld: meson-mx-sdio.c:(.text+0xdd4): undefined reference to `of_platform_device_destroy'
This is because the implementation of of_platform_device_destroy() is
inside an #ifdef CONFIG_OF_ADDRESS section of drivers/of/platform.c.
This driver already depends on OF being enabled, so let's tighten that
constrain a little more so that it depends on OF_ADDRESS instead. This
way we won't try to build this driver on platforms that don't have this
function.
Reported-by: kbuild test robot <lkp@intel.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 3a5089f0332c..31b2a8826b30 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -409,7 +409,7 @@ config MMC_MESON_MX_SDIO
tristate "Amlogic Meson6/Meson8/Meson8b SD/MMC Host Controller support"
depends on ARCH_MESON || COMPILE_TEST
depends on COMMON_CLK
- depends on OF
+ depends on OF_ADDRESS
help
This selects support for the SD/MMC Host Controller on
Amlogic Meson6, Meson8 and Meson8b SoCs.
--
Sent by a computer, using git, on the internet
next prev parent reply other threads:[~2020-04-09 6:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 6:44 [PATCH v2 00/10] Allow COMMON_CLK to be selectable Stephen Boyd
2020-04-09 6:44 ` [PATCH v2 01/10] ARM: Remove redundant COMMON_CLK selects Stephen Boyd
2020-04-09 6:44 ` [PATCH v2 02/10] ARM: Remove redundant CLKDEV_LOOKUP selects Stephen Boyd
2020-05-14 19:56 ` Stephen Boyd
2020-04-09 6:44 ` [PATCH v2 03/10] arm64: tegra: " Stephen Boyd
2020-05-14 19:56 ` Stephen Boyd
2020-04-09 6:44 ` [PATCH v2 04/10] h8300: " Stephen Boyd
2020-05-14 19:56 ` Stephen Boyd
2020-04-09 6:44 ` [PATCH v2 05/10] MIPS: " Stephen Boyd
2020-05-14 19:56 ` Stephen Boyd
2020-04-09 6:44 ` Stephen Boyd [this message]
2020-04-21 14:04 ` [PATCH v2 06/10] mmc: meson-mx-sdio: Depend on OF_ADDRESS and not just OF Ulf Hansson
2020-04-22 10:14 ` Stephen Boyd
2020-04-22 10:39 ` Ulf Hansson
2020-05-14 19:57 ` Stephen Boyd
2020-04-09 6:44 ` [PATCH v2 07/10] clk: Allow the common clk framework to be selectable Stephen Boyd
2020-04-09 10:53 ` Mark Brown
2020-05-14 19:57 ` Stephen Boyd
2020-04-09 6:44 ` [PATCH v2 08/10] ARM: mmp: Remove legacy clk code Stephen Boyd
2020-05-14 19:57 ` Stephen Boyd
2020-04-09 6:44 ` [PATCH v2 09/10] MIPS: Loongson64: Drop asm/clock.h include Stephen Boyd
2020-05-14 19:57 ` Stephen Boyd
2020-04-09 6:44 ` [PATCH v2 10/10] clk: Move HAVE_CLK config out of architecture layer Stephen Boyd
2020-05-14 19:57 ` Stephen Boyd
2020-04-09 8:58 ` [PATCH v2 00/10] Allow COMMON_CLK to be selectable Arnd Bergmann
2020-04-09 9:02 ` [PATCH] mips: loongsoon2ef: remove private clk api Arnd Bergmann
2020-04-13 21:24 ` Philippe Mathieu-Daudé
2020-04-16 16:40 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409064416.83340-7-sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).