From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will@kernel.org>,
akpm@linux-foundation.org,
"K . Prasad" <prasad@linux.vnet.ibm.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>
Subject: Re: [RFC PATCH 8/9] block: genhd: export-GPL generic disk device type
Date: Sat, 11 Apr 2020 08:45:03 +0200 [thread overview]
Message-ID: <20200411064503.GA2576039@kroah.com> (raw)
In-Reply-To: <20200410114444.73be173a@gandalf.local.home>
On Fri, Apr 10, 2020 at 11:44:44AM -0400, Steven Rostedt wrote:
> On Fri, 10 Apr 2020 08:33:57 +0200
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> > I understand your need here, however we do not export things for
> > modules, when there are no in-kernel module users, sorry.
>
> This "we don't cater to out-of-tree modules" even when they are GPL seems
> to always baffle me. Especially since we have a high bar of accepting out
> of tree modules especially if they duplicate some functionality of an
> existing infrastructure of the kernel. I like choice, and coming from
> someone that spent over a decade working on code that has been out of tree,
> I'm a little sympathetic to the cause ;-)
We can't do anything for out-of-tree modules as they suddenly become
"higher priority" than in-tree code if you have to not do specific
changes or extra work for them. Which is not fair at all to the in-tree
code developers at all.
With drivers/staging/ we removed the barrier for accepting any license
compliant driver, so that solved the huge majority of these issues.
> I guess we should be open to allowing LTTng modules in the kernel as well,
> even though it is yet another tracing framework. It's not like its going
> away. And perhaps by doing so, ftrace and perf could start taking advantage
> of anything that LTTng brings.
That is up to you all, as you are the one preventing this from being
merged in the tree, not me :)
Again, don't make us do _more_ work for out-of-tree modules than we do
for in-tree modules, that's just crazy to expect.
thanks,
greg k-h
next prev parent reply other threads:[~2020-04-11 6:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 19:35 [RFC PATCH 0/9] Export information needed by the LTTng kernel tracer Mathieu Desnoyers
2020-04-09 19:35 ` [RFC PATCH 1/9] tracepoint: call vmalloc_sync_mappings() on registration Mathieu Desnoyers
2020-04-09 19:35 ` [RFC PATCH 2/9] bpf: allow up to 13 arguments for tracepoints Mathieu Desnoyers
2020-04-09 19:35 ` [RFC PATCH 3/9] writeback: tracing: pass global_wb_domain as tracepoint parameter Mathieu Desnoyers
2020-04-09 22:33 ` Alexei Starovoitov
2020-04-10 11:54 ` Mathieu Desnoyers
2020-04-09 19:35 ` [RFC PATCH 4/9] stacktrace: export-GPL stack_trace_save_user Mathieu Desnoyers
2020-04-12 8:31 ` Christoph Hellwig
2020-04-09 19:35 ` [RFC PATCH 5/9] sched: export-GPL task_prio Mathieu Desnoyers
2020-04-09 19:35 ` [RFC PATCH 6/9] mm: export-GPL get_pageblock_migratetype Mathieu Desnoyers
2020-04-12 8:14 ` Christoph Hellwig
2020-04-09 19:35 ` [RFC PATCH 7/9] block: genhd: export-GPL gendisk_name Mathieu Desnoyers
2020-04-09 19:35 ` [RFC PATCH 8/9] block: genhd: export-GPL generic disk device type Mathieu Desnoyers
2020-04-10 6:33 ` Greg Kroah-Hartman
2020-04-10 13:31 ` Mathieu Desnoyers
2020-04-10 15:44 ` Steven Rostedt
2020-04-11 6:45 ` Greg Kroah-Hartman [this message]
2020-04-09 19:35 ` [RFC PATCH 9/9] block: genhd: export-GPL generic disk block class Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200411064503.GA2576039@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=prasad@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).