From: Daniel Kiper <daniel.kiper@oracle.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Arvind Sankar <nivedita@alum.mit.edu>,
Dave Young <dyoung@redhat.com>,
pjones@redhat.com, Leif Lindholm <leif@nuviainc.com>,
Borislav Petkov <bp@alien8.de>, Sergey Shatunov <me@prok.pw>,
hpa@zytor.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
mingo@redhat.com, Thomas Gleixner <tglx@linutronix.de>,
X86 ML <x86@kernel.org>, linux-efi <linux-efi@vger.kernel.org>,
initramfs@vger.kernel.org,
Donovan Tremura <neurognostic@protonmail.ch>,
Harald Hoyer <harald@hoyer.xyz>
Subject: Re: [PATCH 1/2] efi/x86: Move efi stub globals from .bss to .data
Date: Tue, 14 Apr 2020 16:57:01 +0200 [thread overview]
Message-ID: <20200414145701.p5ifnnimmuzgfqfh@tomti.i.net-space.pl> (raw)
In-Reply-To: <CAMj1kXHMQgnmdoA+qKLGa=gYg4J2p-DU3-K1LiM=AT61pi+Fvw@mail.gmail.com>
On Fri, Apr 10, 2020 at 05:26:34PM +0200, Ard Biesheuvel wrote:
> On Fri, 10 Apr 2020 at 16:48, Arvind Sankar <nivedita@alum.mit.edu> wrote:
> > On Thu, Apr 09, 2020 at 12:35:30PM -0400, Arvind Sankar wrote:
> > > On Thu, Apr 09, 2020 at 04:47:55PM +0200, Ard Biesheuvel wrote:
> > > > On Thu, 9 Apr 2020 at 16:39, Arvind Sankar <nivedita@alum.mit.edu> wrote:
> > > > >
> > > > > On Wed, Apr 08, 2020 at 09:49:15AM +0200, Ard Biesheuvel wrote:
> > > > > > (add Peter, Leif and Daniel)
> > > > > >
> > > > > > On Wed, 8 Apr 2020 at 09:43, Dave Young <dyoung@redhat.com> wrote:
> > > > > > >
> > > > > > > On 04/06/20 at 02:06pm, Arvind Sankar wrote:
> > > > > > > > Commit
> > > > > > > >
> > > > > > > > 3ee372ccce4d ("x86/boot/compressed/64: Remove .bss/.pgtable from
> > > > > > > > bzImage")
> > > > > > > >
> > > > > > > > removed the .bss section from the bzImage.
> > > > > > > >
> > > > > > > > However, while a PE loader is required to zero-initialize the .bss
> > > > > > > > section before calling the PE entry point, the EFI handover protocol
> > > > > > > > does not currently document any requirement that .bss be initialized by
> > > > > > > > the bootloader prior to calling the handover entry.
> > > > > > > >
> > > > > > > > When systemd-boot is used to boot a unified kernel image [1], the image
> > > > > > > > is constructed by embedding the bzImage as a .linux section in a PE
> > > > > > > > executable that contains a small stub loader from systemd together with
> > > > > > > > additional sections and potentially an initrd. As the .bss section
> > > > > > > > within the bzImage is no longer explicitly present as part of the file,
> > > > > > > > it is not initialized before calling the EFI handover entry.
> > > > > > > > Furthermore, as the size of the embedded .linux section is only the size
> > > > > > > > of the bzImage file itself, the .bss section's memory may not even have
> > > > > > > > been allocated.
> > > > > > >
> > > > > > > I did not follow up the old report, maybe I missed something. But not
> > > > > > > sure why only systemd-boot is mentioned here. I also have similar issue
> > > > > > > with early efi failure. With these two patches applied, it works well
> > > > > > > then.
> > > > > > >
> > > > > > > BTW, I use Fedora 31 + Grub2
> > > > > > >
> > > > > >
> > > > > > OK, so I take it this means that GRUB's PE/COFF loader does not
> > > > > > zero-initialize BSS either? Does it honor the image size in memory if
> > > > > > it exceeds the file size?
> > > > >
> > > > > Dave, that comment was because the previous report was for systemd-boot
> > > > > stub.
> > > > >
> > > > > Ard, should I revise the commit message to make it clear it's not
> > > > > restricted to systemd-boot but anything using handover entry may be
> > > > > affected? Maybe just a "for example, when systemd-boot..." and then a
> > > > > line to say grub2 with the EFI stub patches is also impacted?
> > > > >
> > > >
> > > > Well, the fact the /some/ piece of software is used in production that
> > > > relies on the ill-defined EFI handover protocol is sufficient
> > > > justification, so I don't think it is hugely important to update it.
> > > >
> > > > > https://src.fedoraproject.org/rpms/grub2/blob/f31/f/0001-Add-support-for-Linux-EFI-stub-loading.patch#_743
> > > > >
> > > > > + kernel_mem = grub_efi_allocate_pages_max(lh.pref_address,
> > > > > + BYTES_TO_PAGES(lh.init_size));
> > > > >
> > > > > Looking at this, grub does allocate init_size for the image, but it
> > > > > doesn't zero it out.
> > > > >
> > > > > This call also looks wrong to me though. It allocates at max address of
> > > > > pref_address, which, if it succeeds, will guarantee that the kernel gets
> > > > > loaded entirely below pref_address == LOAD_PHYSICAL_ADDR. In native
> > > > > mode, if it weren't for the EFI stub copying the kernel again, this
> > > > > would cause the startup code to relocate the kernel into unallocated
> > > > > memory. On a mixed-mode boot, this would cause the early page tables
> > > > > setup prior to transitioning to 64-bit mode to be in unallocated memory
> > > > > and potentially get clobbered by the EFI stub.
> > > > >
> > > > > The first try to allocate pref_address should be calling
> > > > > grub_efi_allocate_fixed instead.
> > > >
> > > > Thanks Arvind. I'm sure the Fedora/RedHat folks on cc should be able
> > > > to get these logged somewhere.
> > >
> > > Ok. For dracut, the process for building the unified kernel image needs
> > > a check to make sure the kernel can fit in the space provided for it --
> > > there is 16MiB of space and the distro bzImage's are up to 10-11MiB in
> > > size, so there's some slack left at present.
> > >
> > > Additionally, in mixed-mode, the unified kernel images are quite likely
> > > to end up with early pgtables from startup_32 clobbering the initrd,
> > > independently of the recent kernel changes. Hopefully no-one actually
> > > uses these in mixed-mode.
> >
> > The grub EFI handover entry patch is busted in mixed-mode for another
> > reason -- while it allocates init_size, it doesn't use the correct
> > alignment. I tested on a Debian buster VM in mixed-mode (that was the
> > one I was able to get to install/boot with mixed-mode), and the early
> > pagetable from startup_32 ends up in unallocated memory due to the
> > rounding up of the bzImage address to account for kernel alignment. This
> > would be an existing problem prior to these patches.
> >
> > Should we try to handle this in the kernel? At some point KASLR is going
> > to pick that memory for the kernel and overwrite the pagetables I would
> > think, resulting in sporadic crashes that are almost unreproducible.
>
> Upstream GRUB does not implement the EFI handover protocol at all, and
> the distros all have their own GRUB forks that implement this along
> with mixed mode, secure boot, shim, measured boot etc.
Exactly...
> What you are saying is that GRUB forks turn out to exist that violate
> both the PE/COFF specification and the Linux/x86 boot protocol in a
> way that might break mixed mode, and nobody noticed until you happened
> to find it by code inspection. While I appreciate the effort, I think
> this is where I would like to draw the line, and say that there is
> only so much we can do to work around bugs in out-of-tree forks of
> other projects. So unless it can be done cleanly and without losing
> any of the benefits of the recent cleanup and optimization work, I'd
> say don't bother.
I fully agree!
Daniel
next prev parent reply other threads:[~2020-04-14 14:58 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 15:02 [PATCH 1/2] x86/boot/compressed/64: Remove .bss/.pgtable from bzImage Arvind Sankar
2020-01-09 15:02 ` [PATCH 2/2] x86/boot/compressed: Remove unnecessary sections " Arvind Sankar
2020-02-06 11:44 ` Kees Cook
2020-02-19 16:55 ` [tip: x86/boot] " tip-bot2 for Arvind Sankar
2020-02-22 5:08 ` [PATCH 2/2] " Nathan Chancellor
2020-02-22 6:55 ` Borislav Petkov
2020-02-22 7:02 ` Nathan Chancellor
2020-02-22 7:21 ` Fangrui Song
2020-02-22 7:42 ` Nathan Chancellor
2020-02-22 15:37 ` Arvind Sankar
2020-02-22 16:44 ` Arvind Sankar
2020-02-22 17:18 ` [PATCH] x86/boot/compressed: Fix compressed kernel linking with lld Arvind Sankar
2020-02-22 18:14 ` Nathan Chancellor
2020-02-22 18:58 ` Fangrui Song
2020-02-22 20:17 ` Arvind Sankar
2020-02-22 21:01 ` Fangrui Song
2020-02-22 23:33 ` Nick Desaulniers
2020-02-22 23:57 ` Arvind Sankar
2020-02-23 19:37 ` [PATCH 0/2] Stop generating .eh_frame sections Arvind Sankar
2020-02-24 4:15 ` Nathan Chancellor
2020-02-24 20:49 ` Nick Desaulniers
2020-02-24 21:53 ` Arvind Sankar
2020-02-24 22:01 ` Nick Desaulniers
2020-02-23 19:37 ` [PATCH 1/2] arch/x86: Use -fno-asynchronous-unwind-tables to suppress " Arvind Sankar
2020-02-24 20:33 ` Nick Desaulniers
2020-02-24 21:05 ` Arvind Sankar
2020-02-24 21:12 ` Fangrui Song
2020-02-24 21:17 ` Nick Desaulniers
2020-02-24 21:22 ` Nick Desaulniers
2020-02-23 19:37 ` [PATCH 2/2] arch/x86: Drop unneeded linker script discard of .eh_frame Arvind Sankar
2020-02-24 20:45 ` Nick Desaulniers
2020-02-24 21:33 ` Arvind Sankar
2020-02-24 21:58 ` Nick Desaulniers
2020-02-24 23:21 ` [PATCH v2 0/2] Stop generating .eh_frame sections Arvind Sankar
2020-02-24 23:21 ` [PATCH v2 1/2] arch/x86: Use -fno-asynchronous-unwind-tables to suppress " Arvind Sankar
2020-02-24 23:28 ` Nathan Chancellor
2020-02-24 23:30 ` Nick Desaulniers
2020-02-25 4:10 ` Kees Cook
2020-02-25 16:53 ` [tip: x86/boot] x86/*/Makefile: " tip-bot2 for Arvind Sankar
2020-02-24 23:21 ` [PATCH v2 2/2] arch/x86: Drop unneeded linker script discard of .eh_frame Arvind Sankar
2020-02-24 23:28 ` Nathan Chancellor
2020-02-24 23:33 ` Nick Desaulniers
2020-02-25 4:11 ` Kees Cook
2020-02-25 16:53 ` [tip: x86/boot] x86/vmlinux: " tip-bot2 for Arvind Sankar
2020-02-23 22:00 ` [PATCH] x86/boot/compressed: Fix compressed kernel linking with lld Kees Cook
2020-02-24 6:06 ` Fangrui Song
2020-02-22 17:29 ` [PATCH 2/2] x86/boot/compressed: Remove unnecessary sections from bzImage Borislav Petkov
2020-02-22 17:53 ` Arvind Sankar
2020-02-22 7:42 ` Borislav Petkov
2020-02-22 16:22 ` Arvind Sankar
2020-02-22 23:20 ` Nick Desaulniers
2020-02-24 13:28 ` Michael Matz
2020-02-24 20:51 ` Nick Desaulniers
2020-02-24 21:28 ` Fangrui Song
2020-02-24 21:48 ` Arvind Sankar
2020-02-24 22:17 ` Fangrui Song
2020-02-24 22:43 ` Arvind Sankar
2020-02-24 22:50 ` Fangrui Song
2020-02-24 23:08 ` Arvind Sankar
2020-02-25 5:35 ` --orphan-handling=warn (was Re: [PATCH 2/2] x86/boot/compressed: Remove unnecessary sections) " Kees Cook
2020-02-25 16:42 ` --orphan-handling=warn Arvind Sankar
2020-02-25 18:29 ` --orphan-handling=warn Arvind Sankar
2020-02-25 19:42 ` --orphan-handling=warn Kees Cook
2020-02-25 20:37 ` --orphan-handling=warn Nick Desaulniers
2020-02-25 22:02 ` --orphan-handling=warn Kees Cook
2020-02-26 1:56 ` --orphan-handling=warn Fangrui Song
2020-02-26 5:35 ` --orphan-handling=warn Kees Cook
2020-02-26 19:11 ` --orphan-handling=warn Kristen Carlson Accardi
2020-02-26 19:26 ` --orphan-handling=warn Nick Desaulniers
2020-02-24 11:37 ` [tip: x86/boot] x86/boot/compressed: Remove .eh_frame section from bzImage tip-bot2 for Arvind Sankar
2020-02-24 16:41 ` Arvind Sankar
2020-02-24 17:16 ` Borislav Petkov
2020-02-24 17:28 ` Arvind Sankar
2020-02-05 16:29 ` [PATCH 1/2] x86/boot/compressed/64: Remove .bss/.pgtable " Arvind Sankar
2020-02-18 18:03 ` Arvind Sankar
2020-02-19 12:09 ` Borislav Petkov
2020-02-19 17:57 ` Arvind Sankar
2020-02-19 18:22 ` Borislav Petkov
2020-02-19 19:06 ` Arvind Sankar
2020-02-06 11:18 ` Kees Cook
2020-02-19 16:55 ` [tip: x86/boot] " tip-bot2 for Arvind Sankar
2020-04-05 15:42 ` [PATCH 1/2] " Sergey Shatunov
2020-04-05 23:18 ` Arvind Sankar
2020-04-06 0:00 ` Sergey Shatunov
2020-04-06 3:51 ` Arvind Sankar
2020-04-06 7:32 ` Ard Biesheuvel
2020-04-06 8:47 ` Borislav Petkov
2020-04-06 9:11 ` Ard Biesheuvel
2020-04-06 11:20 ` Borislav Petkov
2020-04-06 13:22 ` Arvind Sankar
2020-04-06 13:29 ` Ard Biesheuvel
2020-04-06 16:01 ` Arvind Sankar
2020-04-06 16:22 ` Ard Biesheuvel
2020-04-06 16:52 ` Arvind Sankar
2020-04-06 16:59 ` Ard Biesheuvel
2020-04-06 18:06 ` [PATCH 1/2] efi/x86: Move efi stub globals from .bss to .data Arvind Sankar
2020-04-06 18:06 ` [PATCH 2/2] efi/x86: Always relocate the kernel for EFI handover entry Arvind Sankar
2020-04-14 8:20 ` [tip: efi/urgent] " tip-bot2 for Arvind Sankar
2020-04-06 18:29 ` [PATCH 1/2] efi/x86: Move efi stub globals from .bss to .data Ard Biesheuvel
2020-04-08 7:43 ` Dave Young
2020-04-08 7:49 ` Ard Biesheuvel
2020-04-09 14:39 ` Arvind Sankar
2020-04-09 14:47 ` Ard Biesheuvel
2020-04-09 16:35 ` Arvind Sankar
2020-04-10 14:47 ` Arvind Sankar
2020-04-10 15:26 ` Ard Biesheuvel
2020-04-14 14:57 ` Daniel Kiper [this message]
2020-04-10 11:26 ` Thomas Meyer
2020-04-10 14:38 ` Arvind Sankar
2020-04-11 8:50 ` Thomas Meyer
2020-04-14 8:20 ` [tip: efi/urgent] " tip-bot2 for Arvind Sankar
2020-04-06 17:21 ` [PATCH 1/2] x86/boot/compressed/64: Remove .bss/.pgtable from bzImage Borislav Petkov
2020-04-06 8:44 ` Ard Biesheuvel
2020-04-06 12:36 ` Sergey Shatunov
2020-04-06 13:20 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414145701.p5ifnnimmuzgfqfh@tomti.i.net-space.pl \
--to=daniel.kiper@oracle.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=harald@hoyer.xyz \
--cc=hpa@zytor.com \
--cc=initramfs@vger.kernel.org \
--cc=leif@nuviainc.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@prok.pw \
--cc=mingo@redhat.com \
--cc=neurognostic@protonmail.ch \
--cc=nivedita@alum.mit.edu \
--cc=pjones@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).