linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joel Fernandes <joel@joelfernandes.org>
To: Quentin Perret <qperret@google.com>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	ctheegal@codeaurora.org, dianders@chromium.org,
	patrick.bellasi@matbug.net, valentin.schneider@arm.com,
	qais.yousef@arm.com, linux-kernel@vger.kernel.org,
	kernel-team@android.com
Subject: Re: [PATCH] sched/core: Fix reset-on-fork from RT with uclamp
Date: Tue, 14 Apr 2020 12:32:18 -0400	[thread overview]
Message-ID: <20200414163218.GA77963@google.com> (raw)
In-Reply-To: <20200414162713.GA256619@google.com>

On Tue, Apr 14, 2020 at 05:27:13PM +0100, Quentin Perret wrote:
> On Tuesday 14 Apr 2020 at 12:21:28 (-0400), Joel Fernandes wrote:
> > Shouldn't this be conditional on p->sched_reset_on_fork instead of deleting
> > the code?
> 
> Right, it's not obvious from the diff, but this code _is_ conditional on
> p->sched_reset_on_fork already. This is what the whole function looks
> like with my patch applied:
> 
> ---8<---
> static void uclamp_fork(struct task_struct *p)
> {
>         enum uclamp_id clamp_id;
> 
>         for_each_clamp_id(clamp_id)
>                 p->uclamp[clamp_id].active = false;
> 
>         if (likely(!p->sched_reset_on_fork))
>                 return;
> 
>         for_each_clamp_id(clamp_id) {
>                 unsigned int clamp_value = uclamp_none(clamp_id);
> 
>                 uclamp_se_set(&p->uclamp_req[clamp_id], clamp_value, false);
>         }

Oh ok, thanks for clarification.

 - Joel


> }
> --->8---
> 
> Thanks,
> Quentin

  reply	other threads:[~2020-04-14 16:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 16:13 [PATCH] sched/core: Fix reset-on-fork from RT with uclamp Quentin Perret
2020-04-14 16:21 ` Joel Fernandes
2020-04-14 16:27   ` Quentin Perret
2020-04-14 16:32     ` Joel Fernandes [this message]
2020-04-14 17:21 ` Patrick Bellasi
2020-04-14 17:25   ` Quentin Perret
2020-04-14 20:45 ` Doug Anderson
2020-04-15  8:20   ` Quentin Perret
2020-04-15 16:31     ` Doug Anderson
2020-04-15 17:47       ` Patrick Bellasi
2020-04-16  8:54         ` Quentin Perret

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200414163218.GA77963@google.com \
    --to=joel@joelfernandes.org \
    --cc=bsegall@google.com \
    --cc=ctheegal@codeaurora.org \
    --cc=dianders@chromium.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=patrick.bellasi@matbug.net \
    --cc=peterz@infradead.org \
    --cc=qais.yousef@arm.com \
    --cc=qperret@google.com \
    --cc=rostedt@goodmis.org \
    --cc=valentin.schneider@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).