From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org,
sakari.ailus@linux.intel.com, andy.shevchenko@gmail.com,
hdegoede@redhat.com, rafael.j.wysocki@intel.com,
linux-kselftest@vger.kernel.org, rostedt@goodmis.org,
sergey.senozhatsky@gmail.com, andriy.shevchenko@linux.intel.com,
shuah@kernel.org, anders.roxell@linaro.org,
lkft-triage@lists.linaro.org, linux@rasmusvillemoes.dk
Subject: Re: [PATCH v1] kobject: make sure parent is not released before children
Date: Wed, 15 Apr 2020 11:18:58 +0300 [thread overview]
Message-ID: <20200415081858.GL2828150@kuha.fi.intel.com> (raw)
In-Reply-To: <20200414204240.186377-1-brendanhiggins@google.com>
On Tue, Apr 14, 2020 at 01:42:40PM -0700, Brendan Higgins wrote:
> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
This patch isn't from me. You can use a tag like "Proposed-by:
Heikki..." or "Co-developed-by: Heikki..." in cases like this.
> Previously, kobjects were released before the associated kobj_types;
> this can cause a kobject deallocation to fail when the kobject has
> children; an example of this is in software_node_unregister_nodes(); it
> calls release on the parent before children meaning that children can be
> released after the parent, which may be needed for removal.
That makes it sound like it's software_node_unregister_nodes() that is
releasing the parent, which isn't the case.
> So, take a reference to the parent before we delete a node to ensure
> that the parent is not released before the children.
>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Fixes: 7589238a8cf3 ("Revert "software node: Simplify software_node_release() function"")
> Link: https://lore.kernel.org/linux-kselftest/CAFd5g44s5NQvT8TG_x4rwbqoa7zWzkV0TX+ETZoQdOB7OwXCPQ@mail.gmail.com/T/#m71f37f3985f2abd7209c8ca8e0fa4edc45e171d6
> Co-developed-by: Brendan Higgins <brendanhiggins@google.com>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---
>
> This patch is based on the diff written by Heikki linked above.
>
> Heikki, can you either reply with a Signed-off-by?
No, I can't sign a patch that didn't actually pass trough my hands:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
So in this case this patch is coming from _you_, not me, and there
can't also be a "Signed-off-by: Heikki..." tag.
You can use another tag to tell everybody that the change was
originally proposed by me (I guess it's "Co-developed-by:
Heikki..."?). Or just explain it in the commit message.
thanks,
--
heikki
prev parent reply other threads:[~2020-04-15 8:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 20:42 [PATCH v1] kobject: make sure parent is not released before children Brendan Higgins
2020-04-14 22:38 ` Randy Dunlap
2020-04-15 6:11 ` Greg KH
2020-04-15 8:46 ` Heikki Krogerus
2020-04-15 9:21 ` Rafael J. Wysocki
2020-04-15 13:10 ` Heikki Krogerus
2020-04-15 13:31 ` Greg KH
2020-04-17 11:39 ` Heikki Krogerus
2020-04-17 16:08 ` Randy Dunlap
2020-04-20 22:03 ` Brendan Higgins
2020-04-15 9:21 ` Greg KH
2020-04-15 11:25 ` Heikki Krogerus
2020-04-15 12:12 ` Greg KH
2020-04-15 8:18 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415081858.GL2828150@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=anders.roxell@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=brendanhiggins@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lkft-triage@lists.linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).