From: Richard Guy Briggs <rgb@redhat.com>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: Amol Grover <frextrite@gmail.com>,
linux-kernel@vger.kernel.org, linux-audit@redhat.com,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v2] kernel: audit.c: Add __rcu notation to RCU pointer
Date: Wed, 15 Apr 2020 11:34:17 -0400 [thread overview]
Message-ID: <20200415153417.svpbimg66vbeuk7u@madcap2.tricolour.ca> (raw)
In-Reply-To: <20191130020742.GF157739@google.com>
On 2019-11-29 21:07, Joel Fernandes wrote:
> On Thu, Nov 28, 2019 at 09:02:03PM +0530, Amol Grover wrote:
> > add __rcu notation to RCU protected global pointer auditd_conn
>
> Again, please use proper punctuation and captilization. This is unacceptable.
> Please put more effort into changelog.
>
> Otherwise the patch diff itself looks good to me, with the above nit
> corrected, you could add my tag to the next revision:
>
> Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
>
> thanks,
>
> - Joel
>
> >
> > Fixes multiple instances of sparse error:
> > error: incompatible types in comparison expression
> > (different address spaces)
Amol or Joel: Is there a reproducer recipe for this?
> > Signed-off-by: Amol Grover <frextrite@gmail.com>
> > ---
> > v2:
> > - fix erroneous RCU pointer initialization
> >
> > kernel/audit.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/audit.c b/kernel/audit.c
> > index da8dc0db5bd3..ff7cfc61f53d 100644
> > --- a/kernel/audit.c
> > +++ b/kernel/audit.c
> > @@ -102,12 +102,13 @@ struct audit_net {
> > * This struct is RCU protected; you must either hold the RCU lock for reading
> > * or the associated spinlock for writing.
> > */
> > -static struct auditd_connection {
> > +struct auditd_connection {
> > struct pid *pid;
> > u32 portid;
> > struct net *net;
> > struct rcu_head rcu;
> > -} *auditd_conn = NULL;
> > +};
> > +static struct auditd_connection __rcu *auditd_conn;
> > static DEFINE_SPINLOCK(auditd_conn_lock);
> >
> > /* If audit_rate_limit is non-zero, limit the rate of sending audit records
> > --
> > 2.24.0
- RGB
--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635
next prev parent reply other threads:[~2020-04-15 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 15:32 [PATCH v2] kernel: audit.c: Add __rcu notation to RCU pointer Amol Grover
2019-11-30 2:07 ` Joel Fernandes
2020-04-15 15:34 ` Richard Guy Briggs [this message]
2020-04-15 16:06 ` Paul Moore
2020-04-15 16:15 ` Richard Guy Briggs
2020-04-15 16:53 ` Ondrej Mosnacek
2020-04-15 19:27 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415153417.svpbimg66vbeuk7u@madcap2.tricolour.ca \
--to=rgb@redhat.com \
--cc=frextrite@gmail.com \
--cc=joel@joelfernandes.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).