From: Ira Weiny <ira.weiny@intel.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jeff Moyer <jmoyer@redhat.com>,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RFC 4/8] fs/ext4: Introduce DAX inode flag
Date: Wed, 15 Apr 2020 13:39:25 -0700 [thread overview]
Message-ID: <20200415203924.GD2309605@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <20200415120846.GG6126@quack2.suse.cz>
On Wed, Apr 15, 2020 at 02:08:46PM +0200, Jan Kara wrote:
> On Mon 13-04-20 21:00:26, ira.weiny@intel.com wrote:
> > From: Ira Weiny <ira.weiny@intel.com>
> >
> > Add a flag to preserve FS_XFLAG_DAX in the ext4 inode.
> >
> > Set the flag to be user visible and changeable. Set the flag to be
> > inherited. Allow applications to change the flag at any time.
> >
> > Finally, on regular files, flag the inode to not be cached to facilitate
> > changing S_DAX on the next creation of the inode.
> >
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > ---
> > fs/ext4/ext4.h | 13 +++++++++----
> > fs/ext4/ioctl.c | 21 ++++++++++++++++++++-
> > 2 files changed, 29 insertions(+), 5 deletions(-)
> >
> > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> > index 61b37a052052..434021fcec88 100644
> > --- a/fs/ext4/ext4.h
> > +++ b/fs/ext4/ext4.h
> > @@ -415,13 +415,16 @@ struct flex_groups {
> > #define EXT4_VERITY_FL 0x00100000 /* Verity protected inode */
> > #define EXT4_EA_INODE_FL 0x00200000 /* Inode used for large EA */
> > #define EXT4_EOFBLOCKS_FL 0x00400000 /* Blocks allocated beyond EOF */
> > +
> > +#define EXT4_DAX_FL 0x00800000 /* Inode is DAX */
> > +
>
> You seem to be using somewhat older kernel... EXT4_EOFBLOCKS_FL doesn't
> exist anymore (but still it's good to leave it reserved for some time so
> the value you've chosen is OK).
I'm on top of 5.6 released. Did this get removed for 5.7? I've heard there are
some boot issues with 5.7-rc1 so I'm holding out for rc2.
>
> > @@ -813,6 +818,17 @@ static int ext4_ioctl_get_es_cache(struct file *filp, unsigned long arg)
> > return error;
> > }
> >
> > +static void ext4_dax_dontcache(struct inode *inode, unsigned int flags)
> > +{
> > + struct ext4_inode_info *ei = EXT4_I(inode);
> > +
> > + if (S_ISDIR(inode->i_mode))
> > + return;
> > +
> > + if ((ei->i_flags ^ flags) == EXT4_DAX_FL)
> > + inode->i_state |= I_DONTCACHE;
> > +}
> > +
>
> You probably want to use the function you've introduced in the XFS series
> here...
you mean:
flag_inode_dontcache()
???
Yes that is done. I sent this prior to v8 (where that was added) of the other
series...
Ira
>
> Honza
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
next prev parent reply other threads:[~2020-04-15 20:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 4:00 [PATCH RFC 0/8] Enable ext4 support for per-file/directory DAX operations ira.weiny
2020-04-14 4:00 ` [PATCH RFC 1/8] fs/ext4: Narrow scope of DAX check in setflags ira.weiny
2020-04-15 11:45 ` Jan Kara
2020-04-14 4:00 ` [PATCH RFC 2/8] fs/ext4: Disallow verity if inode is DAX ira.weiny
2020-04-15 11:58 ` Jan Kara
2020-04-15 12:00 ` Jan Kara
2020-04-15 15:55 ` Theodore Y. Ts'o
2020-04-15 19:21 ` Ira Weiny
2020-04-15 19:14 ` Ira Weiny
2020-04-16 1:29 ` Eric Biggers
2020-04-16 3:48 ` Ira Weiny
2020-04-15 20:34 ` Ira Weiny
2020-04-14 4:00 ` [PATCH RFC 3/8] fs/ext4: Disallow encryption " ira.weiny
2020-04-15 12:02 ` Jan Kara
2020-04-15 20:35 ` Ira Weiny
2020-04-15 16:03 ` Theodore Y. Ts'o
2020-04-15 17:27 ` Dan Williams
2020-04-15 19:54 ` Ira Weiny
2020-04-21 18:41 ` Ira Weiny
2020-04-21 18:56 ` Darrick J. Wong
2020-04-14 4:00 ` [PATCH RFC 4/8] fs/ext4: Introduce DAX inode flag ira.weiny
2020-04-15 12:08 ` Jan Kara
2020-04-15 20:39 ` Ira Weiny [this message]
2020-04-16 10:32 ` Jan Kara
2020-04-16 18:01 ` Theodore Y. Ts'o
2020-04-16 16:25 ` Darrick J. Wong
2020-04-16 22:33 ` Ira Weiny
2020-04-16 22:49 ` Darrick J. Wong
2020-04-17 0:37 ` Ira Weiny
2020-04-17 1:57 ` Darrick J. Wong
2020-04-17 2:20 ` Ira Weiny
2020-04-17 6:43 ` Andreas Dilger
2020-04-17 17:19 ` Ira Weiny
2020-04-14 4:00 ` [PATCH RFC 5/8] fs/ext4: Make DAX mount option a tri-state ira.weiny
2020-04-15 12:51 ` Jan Kara
2020-04-14 4:00 ` [PATCH RFC 6/8] fs/ext4: Update ext4_should_use_dax() ira.weiny
2020-04-15 13:58 ` Jan Kara
2020-04-17 17:16 ` Ira Weiny
2020-04-14 4:00 ` [PATCH RFC 7/8] fs/ext4: Only change S_DAX on inode load ira.weiny
2020-04-15 14:03 ` Jan Kara
2020-04-17 17:18 ` Ira Weiny
2020-04-14 4:00 ` [PATCH RFC 8/8] Documentation/dax: Update DAX enablement for ext4 ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415203924.GD2309605@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).