From: Peter Zijlstra <peterz@infradead.org>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Chen Yu <yu.c.chen@intel.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH 2/2] sched: Extract the task putting code from pick_next_task()
Date: Tue, 21 Apr 2020 01:13:55 +0200 [thread overview]
Message-ID: <20200420231355.GU2483@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <jhjwo69lqcm.mognet@arm.com>
On Mon, Apr 20, 2020 at 11:55:21PM +0100, Valentin Schneider wrote:
> >> + finish_prev_task(rq, prev, rf);
> >
> > I'm not sure I like the name of this function. Perhaps
> > "balance_and_put_prev_task()"? Something more in kind to what the function
> > does.
> >
>
> The 'finish' thing isn't too far from the truth; it's the last thing we
> need to do with the prev task (in terms of sched bookkeeping, I mean) -
> and in Chen's defence ISTR Peter suggested that name.
>
> Seeing as it's a "supercharged" put_prev_task(), I could live with the
> marginally shorter "put_prev_task_balance()".
What Valentin said; it's the last put we do before picking a new task.
Also, I don't like long names. That said, I'm open to short and
appropriate suggestions.
next prev parent reply other threads:[~2020-04-20 23:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 16:31 [PATCH 0/2] sched: Clean up newidle_balance() and pick_next_task() Chen Yu
2020-04-19 16:31 ` [PATCH 1/2] sched: Make newidle_balance() static again Chen Yu
2020-04-19 16:31 ` [PATCH 2/2] sched: Extract the task putting code from pick_next_task() Chen Yu
2020-04-20 22:32 ` Steven Rostedt
2020-04-20 22:55 ` Valentin Schneider
2020-04-20 23:13 ` Peter Zijlstra [this message]
2020-04-21 2:23 ` Steven Rostedt
2020-04-21 7:42 ` Vincent Guittot
2020-04-21 8:38 ` Chen Yu
2020-04-21 8:28 ` Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420231355.GU2483@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).