From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36EAAC5518A for ; Wed, 22 Apr 2020 10:52:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04AFE2073A for ; Wed, 22 Apr 2020 10:52:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587552763; bh=d8UWo6SKeOW35LSQGcKlXwP7KcTbSZkfYdD6nrP5TPU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RQKVix27bUftWWvkD+uYgJq1lPqhsRYXjSqK6M3hMagc5hA12HoCZF4XsPLuwl9A+ fcP71bNMgQuEnG2+GOArZLCkU89nogf9Py+dQsPE2IIElrQv8zKSuzUzSByoAOVco9 mstLTj9uzIRd9rguSuYyr0dvDC4DoGDD87b9cUrc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732157AbgDVKwm (ORCPT ); Wed, 22 Apr 2020 06:52:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:37634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728910AbgDVKJ4 (ORCPT ); Wed, 22 Apr 2020 06:09:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 40B1B20575; Wed, 22 Apr 2020 10:09:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587550194; bh=d8UWo6SKeOW35LSQGcKlXwP7KcTbSZkfYdD6nrP5TPU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iS9k72FfPDaT4Q327sV99HoFI4+hj7zntR2R+k4vxwDnlkRVU1AVCvDfxc7N7vsa6 nxrb3AG4BO0bQWwx8N447yXT8XwEidaQ4x15Nd6wMVhi1mIcW1xQNUWMCcLFik3P6A Q3SJJn5+l13DbUT/nNxnq4iDA9gjzwO7ELl39o/8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jan Engelhardt , "Rafael J. Wysocki" Subject: [PATCH 4.14 046/199] acpi/x86: ignore unspecified bit positions in the ACPI global lock field Date: Wed, 22 Apr 2020 11:56:12 +0200 Message-Id: <20200422095102.535352496@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095057.806111593@linuxfoundation.org> References: <20200422095057.806111593@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jan Engelhardt commit ecb9c790999fd6c5af0f44783bd0217f0b89ec2b upstream. The value in "new" is constructed from "old" such that all bits defined as reserved by the ACPI spec[1] are left untouched. But if those bits do not happen to be all zero, "new < 3" will not evaluate to true. The firmware of the laptop(s) Medion MD63490 / Akoya P15648 comes with garbage inside the "FACS" ACPI table. The starting value is old=0x4944454d, therefore new=0x4944454e, which is >= 3. Mask off the reserved bits. [1] https://uefi.org/sites/default/files/resources/ACPI_6_2.pdf Link: https://bugzilla.kernel.org/show_bug.cgi?id=206553 Cc: All applicable Signed-off-by: Jan Engelhardt Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- arch/x86/kernel/acpi/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/x86/kernel/acpi/boot.c +++ b/arch/x86/kernel/acpi/boot.c @@ -1738,7 +1738,7 @@ int __acpi_acquire_global_lock(unsigned new = (((old & ~0x3) + 2) + ((old >> 1) & 0x1)); val = cmpxchg(lock, old, new); } while (unlikely (val != old)); - return (new < 3) ? -1 : 0; + return ((new & 0x3) < 3) ? -1 : 0; } int __acpi_release_global_lock(unsigned int *lock)