From: David Miller <davem@davemloft.net>
To: gshan@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
netanel@amazon.com, akiyano@amazon.com, gtzalik@amazon.com,
saeedb@amazon.com, zorik@amazon.com
Subject: Re: [PATCH] net/ena: Fix build warning in ena_xdp_set()
Date: Fri, 24 Apr 2020 16:53:04 -0700 (PDT) [thread overview]
Message-ID: <20200424.165304.2022999573149534624.davem@davemloft.net> (raw)
In-Reply-To: <20200424000146.6188-1-gshan@redhat.com>
From: Gavin Shan <gshan@redhat.com>
Date: Fri, 24 Apr 2020 10:01:46 +1000
> This fixes the following build warning in ena_xdp_set()
>
> In file included from ./include/net/inet_sock.h:19,
> from ./include/net/ip.h:27,
> from drivers/net/ethernet/amazon/ena/ena_netdev.c:46:
> drivers/net/ethernet/amazon/ena/ena_netdev.c: In function \
> ‘ena_xdp_set’: \
> drivers/net/ethernet/amazon/ena/ena_netdev.c:557:6: warning: \
> format ‘%lu’ \
> expects argument of type ‘long unsigned int’, but argument 4 \
> has type ‘int’ \
> [-Wformat=] "Failed to set xdp program, the current MTU (%d) is \
> larger than the maximum allowed MTU (%lu) while xdp is on",
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
The type of the argument is configuration dependent, this is because
sometimes one of the terms to define ENA_XDP_MAX_MTU is PAGE_SIZE and
sometimes it is SZ_16K. And this determines whether it evaluates to
a long or not.
So your patch will just cause warnings in other configurations.
A better fix is therefore necessary.
next prev parent reply other threads:[~2020-04-24 23:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 0:01 [PATCH] net/ena: Fix build warning in ena_xdp_set() Gavin Shan
2020-04-24 23:53 ` David Miller [this message]
2020-04-27 16:27 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424.165304.2022999573149534624.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akiyano@amazon.com \
--cc=gshan@redhat.com \
--cc=gtzalik@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).