From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: linux-pci@vger.kernel.org
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Huacai Chen <chenhc@lemote.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Andrew Murray <amurray@thegoodpenguin.co.uk>,
Paul Burton <paulburton@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: [PATCH v5 2/6] PCI: Don't disable decoding when mmio_always_on is set
Date: Fri, 24 Apr 2020 21:08:33 +0800 [thread overview]
Message-ID: <20200424130847.328584-3-jiaxun.yang@flygoat.com> (raw)
In-Reply-To: <20200424130847.328584-1-jiaxun.yang@flygoat.com>
Don't disable MEM/IO decoing when a device have both non_compliant_bars
and mmio_always_on.
That would allow us quirk devices with junk in BARs but can't disable
their decoding.
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
drivers/pci/probe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 77b8a145c39b..d9c2c3301a8a 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -1822,7 +1822,7 @@ int pci_setup_device(struct pci_dev *dev)
/* Device class may be changed after fixup */
class = dev->class >> 8;
- if (dev->non_compliant_bars) {
+ if (dev->non_compliant_bars && !dev->mmio_always_on) {
pci_read_config_word(dev, PCI_COMMAND, &cmd);
if (cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) {
pci_info(dev, "device has non-compliant BARs; disabling IO/MEM decoding\n");
--
2.26.0.rc2
next prev parent reply other threads:[~2020-04-24 13:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 13:08 [PATCH v5 0/6] Loongson PCI Generic Driver Jiaxun Yang
2020-04-24 13:08 ` [PATCH v5 1/6] PCI: OF: Don't remap iospace on unsupported platform Jiaxun Yang
2020-04-24 17:47 ` Rob Herring
2020-04-24 18:03 ` Jiaxun Yang
2020-04-24 19:05 ` Rob Herring
2020-04-24 13:08 ` Jiaxun Yang [this message]
2020-04-24 13:08 ` [PATCH v5 3/6] PCI: Add Loongson PCI Controller support Jiaxun Yang
2020-04-24 18:22 ` Rob Herring
2020-04-24 13:08 ` [PATCH v5 4/6] dt-bindings: Document Loongson PCI Host Controller Jiaxun Yang
2020-04-24 18:38 ` Rob Herring
2020-04-24 13:08 ` [PATCH v5 5/6] MIPS: DTS: Loongson64: Add PCI Controller Node Jiaxun Yang
2020-04-24 19:10 ` Rob Herring
2020-04-24 13:08 ` [PATCH v5 6/6] MIPS: Loongson64: Switch to generic PCI driver Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424130847.328584-3-jiaxun.yang@flygoat.com \
--to=jiaxun.yang@flygoat.com \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bhelgaas@google.com \
--cc=chenhc@lemote.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=paulburton@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).