From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Marciniszyn, Mike" <mike.marciniszyn@intel.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
"Dalessandro, Dennis" <dennis.dalessandro@intel.com>,
Doug Ledford <dledford@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] IB/rdmavt: return proper error code
Date: Fri, 24 Apr 2020 11:00:47 -0300 [thread overview]
Message-ID: <20200424140047.GF26002@ziepe.ca> (raw)
In-Reply-To: <BY5PR11MB3958DBE0C624D035D00E5AAB86D00@BY5PR11MB3958.namprd11.prod.outlook.com>
On Fri, Apr 24, 2020 at 01:50:22PM +0000, Marciniszyn, Mike wrote:
> > Subject: Re: [PATCH] IB/rdmavt: return proper error code
> >
> > On Thu, Apr 23, 2020 at 01:04:34PM +0100, Sudip Mukherjee wrote:
> > > The function rvt_create_mmap_info() can return either NULL or an error
> > > in ERR_PTR(). Check properly for both the error type and return the
> > > error code accordingly.
> >
> > Please fix rvt_create_mmap_info to always return ERR_PTR, never null
> > on failure.
> >
> > Thanks,
> > Jason
>
> I agree on the ERR_PTR return, but the patch is incomplete.
>
> The original patch:
>
> Fixes: ff23dfa13457 ("IB: Pass only ib_udata in function prototypes")
>
> Broke all the call sites: cq.c, srq.c, and qp.c.
Sure looks like it, someone make a patch..
Jason
next prev parent reply other threads:[~2020-04-24 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 12:04 [PATCH] IB/rdmavt: return proper error code Sudip Mukherjee
2020-04-23 14:09 ` Jason Gunthorpe
2020-04-24 12:27 ` Dennis Dalessandro
2020-04-24 13:50 ` Marciniszyn, Mike
2020-04-24 14:00 ` Jason Gunthorpe [this message]
2020-04-23 12:48 Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424140047.GF26002@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).