From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Bakker <xc-racer2@live.ca>
Cc: kgene@kernel.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/13] arm: dts: s5pv210: Correct FIMC definitions
Date: Tue, 28 Apr 2020 12:32:27 +0200 [thread overview]
Message-ID: <20200428103227.GE23963@kozik-lap> (raw)
In-Reply-To: <BN6PR04MB0660823C87DE000BCDF36C3AA3AE0@BN6PR04MB0660.namprd04.prod.outlook.com>
On Sun, Apr 26, 2020 at 11:36:03AM -0700, Jonathan Bakker wrote:
> The extended mainscaler is only available on FIMC1 and there
> are minimum pixel alignments that differ from the default.
> Additionally, the cam-if interface is available on all three
> while FIMC2 has no rotators. The lcd-wb interface is supported
> on FIMC1.
>
> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> ---
> arch/arm/boot/dts/s5pv210.dtsi | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
> index b3b6ad2889f9..3cbf6c05f42a 100644
> --- a/arch/arm/boot/dts/s5pv210.dtsi
> +++ b/arch/arm/boot/dts/s5pv210.dtsi
> @@ -626,7 +626,7 @@
> clock-names = "fimc",
> "sclk_fimc";
> samsung,pix-limits = <4224 8192 1920 4224>;
> - samsung,mainscaler-ext;
> + samsung,min-pix-alignment = <16 8>;
> samsung,cam-if;
> };
>
> @@ -639,9 +639,11 @@
> <&clocks SCLK_FIMC1>;
> clock-names = "fimc",
> "sclk_fimc";
> - samsung,pix-limits = <4224 8192 1920 4224>;
> samsung,mainscaler-ext;
> + samsung,min-pix-alignment = <1 1>;
> + samsung,pix-limits = <4224 8192 1920 4224>;
The line just moved around. I guess this was not intended?
Best regards,
Krzysztof
> samsung,cam-if;
> + samsung,lcd-wb;
> };
>
> fimc2: fimc@fb400000 {
> @@ -653,9 +655,10 @@
> <&clocks SCLK_FIMC2>;
> clock-names = "fimc",
> "sclk_fimc";
> - samsung,pix-limits = <4224 8192 1920 4224>;
> - samsung,mainscaler-ext;
> - samsung,lcd-wb;
> + samsung,pix-limits = <1920 8192 1280 1920>;
> + samsung,min-pix-alignment = <16 8>;
> + samsung,rotators = <0>;
> + samsung,cam-if;
> };
> };
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-04-28 10:33 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200426183604.28494-1-xc-racer2@live.ca>
2020-04-26 18:35 ` [PATCH 01/13] arm: dts: s5pv210: Add helper define for sleep gpio config Jonathan Bakker
2020-04-26 18:35 ` [PATCH 02/13] arm: dts: s5pv210: fascinate4g: Add sleep GPIO configuration Jonathan Bakker
2020-04-28 10:02 ` Krzysztof Kozlowski
2020-04-28 23:49 ` Jonathan Bakker
2020-05-01 13:10 ` Krzysztof Kozlowski
2020-04-26 18:35 ` [PATCH 03/13] arm: dts: s5pv210: galaxys: " Jonathan Bakker
2020-04-26 18:35 ` [PATCH 04/13] arm: dts: s5pv210: aries: Set keep-power-in-suspend for SDHCI1 Jonathan Bakker
2020-04-26 18:35 ` [PATCH 05/13] arm: dts: s5pv210: aries: Disable pulls on GPIO i2c adapters Jonathan Bakker
2020-04-26 18:35 ` [PATCH 06/13] arm: dts: s5pv210: aries: Add support for more devices Jonathan Bakker
2020-04-28 10:20 ` Krzysztof Kozlowski
2020-04-28 23:32 ` Jonathan Bakker
2020-05-01 13:31 ` Krzysztof Kozlowski
2020-05-01 19:43 ` Jonathan Bakker
2020-04-26 18:35 ` [PATCH 07/13] arm: dts: s5pv210: galaxys: Add si470x fmradio Jonathan Bakker
2020-04-26 18:35 ` [PATCH 08/13] arm: dts: s5pv210: aries: Disable pull for vibrator ena GPIO Jonathan Bakker
2020-04-26 18:36 ` [PATCH 09/13] arm: dts: s5pv210: Add an ADC node Jonathan Bakker
2020-04-28 10:26 ` Krzysztof Kozlowski
2020-04-28 22:27 ` Jonathan Bakker
2020-04-26 18:36 ` [PATCH 10/13] arm: dts: s5pv210: aries: Enable " Jonathan Bakker
2020-04-28 10:29 ` Krzysztof Kozlowski
2020-04-28 22:26 ` Jonathan Bakker
2020-04-26 18:36 ` [PATCH 11/13] arm: dts: s5pv210: Assign clocks to MMC devices Jonathan Bakker
2020-04-26 18:36 ` [PATCH 12/13] arm: dts: s5pv210: Correct FIMC definitions Jonathan Bakker
2020-04-28 10:32 ` Krzysztof Kozlowski [this message]
2020-04-28 22:31 ` Jonathan Bakker
2020-04-26 18:36 ` [PATCH 13/13] arm: dts: s5pv210: aries: Set MAX8998 GPIO pulls Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 00/18] S5PV210 and Aries DTS improvements Jonathan Bakker
2020-05-04 15:15 ` Krzysztof Kozlowski
[not found] ` <20200501235019.24022-1-xc-racer2@live.ca>
2020-05-01 23:50 ` [PATCH v2 01/18] ARM: dts: s5pv210: Add helper define for sleep gpio config Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 02/18] ARM: dts: s5pv210: Add sleep GPIO configuration for fascinate4g Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 03/18] ARM: dts: s5pv210: Add sleep GPIO configuration for galaxys Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 04/18] ARM: dts: s5pv210: Set keep-power-in-suspend for SDHCI1 on aries Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 05/18] ARM: dts: s5pv210: Disable pulls on GPIO i2c adapters for aries Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 06/18] ARM: dts: s5pv210: Add WM8994 support to aries boards Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 07/18] ARM: dts: s5pv210: Add FSA9480 support to Aries boards Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 08/18] ARM: dts: s5pv210: Add touchkey support to aries boards Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 09/18] ARM: dts: s5pv210: Add panel " Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 10/18] ARM: dts: s5pv210: Add remaining i2c-gpio adapters to aries Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 11/18] ARM: dts: s5pv210: Add si470x fmradio to galaxys Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 12/18] ARM: dts: s5pv210: Disable pull for vibrator ena GPIO on aries Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 13/18] ARM: dts: s5pv210: Add an ADC node Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 14/18] ARM: dts: s5pv210: Enable ADC on aries boards Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 15/18] ARM: dts: s5pv210: Assign clocks to MMC devices on aries Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 16/18] ARM: dts: s5pv210: Correct FIMC definitions Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 17/18] ARM: dts: s5pv210: Set MAX8998 GPIO pulls on aries Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 18/18] ARM: dts: s5pv210: Correct gpi gpio node name Jonathan Bakker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428103227.GE23963@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).