From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Clark Williams <williams@redhat.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Song Liu <songliubraving@fb.com>
Subject: Re: [PATCH 4/7] perf bpf: Decouple creating the evlist from adding the SB event
Date: Tue, 28 Apr 2020 14:21:34 -0300 [thread overview]
Message-ID: <20200428172134.GA5460@kernel.org> (raw)
In-Reply-To: <20200428094851.GE1476763@krava>
Em Tue, Apr 28, 2020 at 11:48:51AM +0200, Jiri Olsa escreveu:
> On Mon, Apr 27, 2020 at 06:19:32PM -0300, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > Renaming bpf_event__add_sb_event() to evlist__add_sb_event() and
> > requiring that the evlist be allocated beforehand.
>
> hum, this seems to be done in previous patch, maybe you
> need to squash this with the previous one?
Right, doing it now.
> jirka
>
> >
> > This will allow using the same side band thread and evlist to be used
> > for multiple purposes in addition to react to PERF_RECORD_BPF_EVENT soon
> > after they are generated.
> >
> > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > Cc: Jiri Olsa <jolsa@kernel.org>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Song Liu <songliubraving@fb.com>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > ---
> > tools/perf/util/bpf-event.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/bpf-event.h b/tools/perf/util/bpf-event.h
> > index 2c7a50509659..68f315c3df5b 100644
> > --- a/tools/perf/util/bpf-event.h
> > +++ b/tools/perf/util/bpf-event.h
> > @@ -45,7 +45,7 @@ static inline int machine__process_bpf(struct machine *machine __maybe_unused,
> > return 0;
> > }
> >
> > -static inline int evlist__add_bpf_sb_event(struct evlist **evlist __maybe_unused,
> > +static inline int evlist__add_bpf_sb_event(struct evlist *evlist __maybe_unused,
> > struct perf_env *env __maybe_unused)
> > {
> > return 0;
> > --
> > 2.21.1
> >
>
--
- Arnaldo
next prev parent reply other threads:[~2020-04-28 17:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 21:19 [RFC PATCHSET] Implement --switch-output-events Arnaldo Carvalho de Melo
2020-04-27 21:19 ` [PATCH 1/7] perf record: Move sb_evlist to 'struct record' Arnaldo Carvalho de Melo
2020-04-27 21:19 ` [PATCH 2/7] perf top: Move sb_evlist to 'struct perf_top' Arnaldo Carvalho de Melo
2020-04-27 21:19 ` [PATCH 3/7] perf bpf: Decouple creating the evlist from adding the SB event Arnaldo Carvalho de Melo
2020-04-27 21:19 ` [PATCH 4/7] " Arnaldo Carvalho de Melo
2020-04-28 9:48 ` Jiri Olsa
2020-04-28 17:21 ` Arnaldo Carvalho de Melo [this message]
2020-04-27 21:19 ` [PATCH 5/7] perf parse-events: Add parse_events_option() variant that creates evlist Arnaldo Carvalho de Melo
2020-04-27 21:19 ` [PATCH 6/7] perf evlist: Allow reusing the side band thread for more purposes Arnaldo Carvalho de Melo
2020-04-27 21:19 ` [PATCH 7/7] perf record: Introduce --switch-output-event Arnaldo Carvalho de Melo
2020-04-28 9:48 ` Jiri Olsa
2020-04-28 12:16 ` Arnaldo Carvalho de Melo
2020-04-28 13:22 ` Jiri Olsa
2020-04-28 18:05 ` Arnaldo Carvalho de Melo
2020-04-29 8:18 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428172134.GA5460@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).