From: David Miller <davem@davemloft.net>
To: frextrite@gmail.com
Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, kuba@kernel.org,
kaber@trash.net, sfr@canb.auug.org.au, cai@lca.pw,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
joel@joelfernandes.org, madhuparnabhowmik10@gmail.com,
paulmck@kernel.org
Subject: Re: [PATCH net v2 1/2] ipmr: Fix RCU list debugging warning
Date: Thu, 14 May 2020 18:01:25 -0700 (PDT) [thread overview]
Message-ID: <20200514.180125.970958854699328151.davem@davemloft.net> (raw)
In-Reply-To: <20200514180102.26425-1-frextrite@gmail.com>
From: Amol Grover <frextrite@gmail.com>
Date: Thu, 14 May 2020 23:31:02 +0530
> ipmr_for_each_table() macro uses list_for_each_entry_rcu()
> for traversing outside of an RCU read side critical section
> but under the protection of rtnl_mutex. Hence, add the
> corresponding lockdep expression to silence the following
> false-positive warning at boot:
>
> [ 4.319347] =============================
> [ 4.319349] WARNING: suspicious RCU usage
> [ 4.319351] 5.5.4-stable #17 Tainted: G E
> [ 4.319352] -----------------------------
> [ 4.319354] net/ipv4/ipmr.c:1757 RCU-list traversed in non-reader section!!
>
> Fixes: f0ad0860d01e ("ipv4: ipmr: support multiple tables")
> Signed-off-by: Amol Grover <frextrite@gmail.com>
Applied.
prev parent reply other threads:[~2020-05-15 1:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 18:01 [PATCH net v2 1/2] ipmr: Fix RCU list debugging warning Amol Grover
2020-05-14 18:01 ` [PATCH net v2 2/2] ipmr: Add lockdep expression to ipmr_for_each_table macro Amol Grover
2020-05-15 1:01 ` David Miller
2020-05-15 1:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514.180125.970958854699328151.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cai@lca.pw \
--cc=frextrite@gmail.com \
--cc=joel@joelfernandes.org \
--cc=kaber@trash.net \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhuparnabhowmik10@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).