From: Lee Jones <lee.jones@linaro.org>
To: devicetree@vger.kernel.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
David Collins <collinsd@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] mfd: Introduce QTI I2C PMIC controller
Date: Fri, 15 May 2020 11:45:20 +0100 [thread overview]
Message-ID: <20200515104520.GK271301@dell> (raw)
In-Reply-To: <20200501011319.GA28441@codeaurora.org>
On Thu, 30 Apr 2020, Guru Das Srinagesh wrote:
> On Wed, Apr 29, 2020 at 08:50:10AM +0100, Lee Jones wrote:
> > On Tue, 28 Apr 2020, Guru Das Srinagesh wrote:
> >
> > > The Qualcomm Technologies, Inc. I2C PMIC Controller is used by
> > > multi-function PMIC devices which communicate over the I2C bus. The
> > > controller enumerates all child nodes as platform devices, and
> > > instantiates a regmap interface for them to communicate over the I2C
> > > bus.
> > >
> > > The controller also controls interrupts for all of the children platform
> > > devices. The controller handles the summary interrupt by deciphering
> > > which peripheral triggered the interrupt, and which of the peripheral
> > > interrupts were triggered. Finally, it calls the interrupt handlers for
> > > each of the virtual interrupts that were registered.
> > >
> > > Nicholas Troast is the original author of this driver.
> > >
> > > Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
> > > ---
> > > drivers/mfd/Kconfig | 11 +
> > > drivers/mfd/Makefile | 1 +
> > > drivers/mfd/qcom-i2c-pmic.c | 737 ++++++++++++++++++++++++++++++++++++++++++++
> >
> > The vast majority of this driver deals with IRQ handling. Why can't
> > this be split out into its own IRQ Chip driver and moved to
> > drivers/irqchip?
>
> There appear to be quite a few in-tree MFD drivers that register IRQ
> controllers, like this driver does:
>
> $ grep --exclude-dir=.git -rnE "irq_domain_(add|create).+\(" drivers/mfd | wc -l
> 23
>
> As a further example, drivers/mfd/stpmic1.c closely resembles this
> driver in that it uses both devm_regmap_add_irq_chip() as well as
> devm_of_platform_populate().
>
> As such, it seems like this driver is in line with some of the
> architectural choices that have been accepted in already-merged drivers.
> Could you please elaborate on your concerns?
It is true that *basic* IRQ domain support has been added to these
drivers in the past. However, IMHO the support added to this driver
goes beyond those realms such that it would justify a driver of its
own.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-05-15 10:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 0:30 [PATCH v1 0/2] Introduce QTI I2C PMIC controller Guru Das Srinagesh
2020-04-29 0:30 ` [PATCH v1 1/2] dt-bindings: mfd: Document " Guru Das Srinagesh
2020-04-29 7:51 ` Lee Jones
2020-04-29 21:01 ` Rob Herring
2020-04-29 0:30 ` [PATCH v1 2/2] mfd: Introduce " Guru Das Srinagesh
2020-04-29 7:50 ` Lee Jones
2020-05-01 1:13 ` Guru Das Srinagesh
2020-05-01 1:18 ` Joe Perches
2020-05-01 1:28 ` Guru Das Srinagesh
2020-05-15 10:45 ` Lee Jones [this message]
2020-05-19 18:57 ` Guru Das Srinagesh
2020-05-20 6:39 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515104520.GK271301@dell \
--to=lee.jones@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=subbaram@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).