From: Andrew Lunn <andrew@lunn.ch>
To: tanhuazhong <tanhuazhong@huawei.com>
Cc: f.fainelli@gmail.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com, kuba@kernel.org,
Yufeng Mo <moyufeng@huawei.com>,
Jian Shen <shenjian15@huawei.com>
Subject: Re: [PATCH net-next] net: phy: realtek: add loopback support for RTL8211F
Date: Mon, 18 May 2020 16:50:39 +0200 [thread overview]
Message-ID: <20200518145039.GA624248@lunn.ch> (raw)
In-Reply-To: <cb82153d-e14e-8e97-b3b8-210135fbdee6@huawei.com>
> Hi, Andrew.
>
> There are two type of phys we are using, rtl8211f and "Marvell 88E1512".
> "Marvell 88E1512" has already supported loopback
> (f0f9b4ed2338 ("net: phy: Add phy loopback support in net phy framework")).
> So now we adds loopback support to the rtl8211f.
> From the data sheet other phys should support this loopback as well, but
> we have no way to verify it. What's your suggestion?
So you checked the datasheets for the RTL8201CP, RTL8201F, RTL8208,
RTL8211B, RTL8211DN, etc?
For all those you have datasheets for, please also add loopback
support. I'm just trying to avoid one PHY from twelve in that driver
having loopback support, when they all probably can.
Andrew
prev parent reply other threads:[~2020-05-18 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 8:25 [PATCH net-next] net: phy: realtek: add loopback support for RTL8211F Huazhong Tan
2020-05-13 13:12 ` Andrew Lunn
2020-05-14 1:32 ` tanhuazhong
2020-05-18 1:49 ` tanhuazhong
2020-05-18 14:50 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518145039.GA624248@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxarm@huawei.com \
--cc=moyufeng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=shenjian15@huawei.com \
--cc=tanhuazhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).