From: Andrew Morton <akpm@linux-foundation.org>
To: 王程刚 <wangchenggang@vivo.com>
Cc: "'Masami Hiramatsu'" <mhiramat@kernel.org>,
"'Steven Rostedt \(VMware'" <rostedt@goodmis.org>,
"'Kees Cook'" <keescook@chromium.org>,
"'Thomas Gleixner'" <tglx@linutronix.de>,
"'Dominik Brodowski'" <linux@dominikbrodowski.net>,
"'Arvind Sankar'" <nivedita@alum.mit.edu>,
"'Mike Rapoport'" <rppt@linux.ibm.com>,
"'Alexander Potapenko'" <glider@google.com>,
<linux-kernel@vger.kernel.org>, <kernel@vivo.com>
Subject: Re: [PATCH] init/main.c: Print all command line when boot
Date: Mon, 18 May 2020 20:44:15 -0700 [thread overview]
Message-ID: <20200518204415.d1a3adaba597ce5b232b4b2a@linux-foundation.org> (raw)
In-Reply-To: <010201d62d8d$bf7605f0$3e6211d0$@vivo.com>
On Tue, 19 May 2020 11:29:46 +0800 王程刚 <wangchenggang@vivo.com> wrote:
> Function pr_notice print max length maybe less than the command line length,
> need more times to print all.
> For example, arm64 has 2048 bytes command line length, but printk maximum
> length is only 1024 bytes.
I can see why that might be a problem!
> --- a/init/main.c
> +++ b/init/main.c
> @@ -825,6 +825,16 @@ void __init __weak arch_call_rest_init(void)
> rest_init();
> }
>
> +static void __init print_cmdline(void)
> +{
> + const char *prefix = "Kernel command line: ";
const char prefix[] = "...";
might generate slightly more efficient code.
> + int len = -strlen(prefix);
hm, tricky. What the heck does printk() actually return to the caller?
Seems that we forgot to document this, and there are so many different
paths which a printk call can take internally that I'm not confident
that they all got it right!
> + len += pr_notice("%s%s\n", prefix, boot_command_line);
> + while (boot_command_line[len])
> + len += pr_notice("%s\n", &boot_command_line[len]);
> +}
Did you really intend to insert a \n into the output every 1024'th
character?
And what effect does this additional \n have upon the code logic?
Doesn't this cause the printk() return value to be one greater than
expected each time it is called?
>
> ...
>
next prev parent reply other threads:[~2020-05-19 3:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 3:29 [PATCH] init/main.c: Print all command line when boot 王程刚
2020-05-19 3:44 ` Andrew Morton [this message]
2020-05-19 5:09 ` Joe Perches
2020-05-19 14:34 ` Arvind Sankar
2020-05-19 19:42 ` [RFC PATCH 0/2] printk/init: multi-line kernel command line logging Joe Perches
2020-05-19 19:42 ` [RFC PATCH 1/2] printk: Move and rename maximum printk output line length defines Joe Perches
2020-05-21 13:49 ` Petr Mladek
2020-05-19 19:42 ` [RFC PATCH 2/2] init: Allow multi-line output of kernel command line Joe Perches
2020-05-20 4:41 ` Sergey Senozhatsky
2020-05-20 4:58 ` Joe Perches
2020-05-20 12:10 ` Sergey Senozhatsky
2020-05-20 20:36 ` Joe Perches
2020-05-21 1:00 ` Andrew Morton
2020-05-21 2:09 ` Joe Perches
2020-05-21 4:36 ` Sergey Senozhatsky
2020-05-21 4:40 ` Andrew Morton
2020-05-21 12:31 ` Petr Mladek
2020-05-21 15:08 ` Arvind Sankar
2020-05-21 12:48 ` Sergey Senozhatsky
2020-05-21 4:32 ` Sergey Senozhatsky
2020-05-21 13:46 ` Petr Mladek
2020-05-21 15:59 ` Arvind Sankar
2020-05-21 16:09 ` Joe Perches
2020-06-03 8:48 ` [init] d0bcc26c0d: BUG:kernel_hang_in_early-boot_stage,last_printk:early_console_in_setup_code kernel test robot
2020-05-21 18:40 ` [PATCH] printk: Move and rename maximum printk output line length defines Joe Perches
2020-05-25 8:38 ` Sergey Senozhatsky
2020-05-20 14:01 ` [PATCH] init/main.c: Print all command line when boot Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518204415.d1a3adaba597ce5b232b4b2a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=glider@google.com \
--cc=keescook@chromium.org \
--cc=kernel@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mhiramat@kernel.org \
--cc=nivedita@alum.mit.edu \
--cc=rostedt@goodmis.org \
--cc=rppt@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=wangchenggang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).