From: Richard Guy Briggs <rgb@redhat.com>
To: Amol Grover <frextrite@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
James Morris <jamorris@linux.microsoft.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jann Horn <jannh@google.com>, David Howells <dhowells@redhat.com>,
Shakeel Butt <shakeelb@google.com>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Moore <paul@paul-moore.com>, Eric Paris <eparis@redhat.com>,
"Paul E . McKenney" <paulmck@kernel.org>,
linux-kernel@vger.kernel.org,
Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>,
linux-audit@redhat.com, Joel Fernandes <joel@joelfernandes.org>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH 1/3 RESEND] sched: Remove __rcu annotation from cred pointer
Date: Mon, 25 May 2020 09:17:41 -0400 [thread overview]
Message-ID: <20200525131741.s6lgb263fpo5uszk@madcap2.tricolour.ca> (raw)
In-Reply-To: <20200524081117.GA29@workstation-LAP.localdomain>
On 2020-05-24 13:41, Amol Grover wrote:
> On Thu, Apr 02, 2020 at 11:26:38AM +0530, Amol Grover wrote:
> > task_struct::cred (subjective credentials) is *always* used
> > task-synchronously, hence, does not require RCU semantics.
> >
> > task_struct::real_cred (objective credentials) can be used in
> > RCU context and its __rcu annotation is retained.
> >
> > However, task_struct::cred and task_struct::real_cred *may*
> > point to the same object, hence, the object pointed to by
> > task_struct::cred *may* have RCU delayed freeing.
> >
> > Suggested-by: Jann Horn <jannh@google.com>
> > Co-developed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> > Signed-off-by: Amol Grover <frextrite@gmail.com>
>
> Hello everyone,
>
> Could you please go through patches 1/3 and 2/3 and if deemed OK, give
> your acks. I sent the original patch in beginning of February (~4 months
> back) and resent the patches again in beginning of April due to lack of
> traffic. Paul Moore was kind enough to ack twice - the 3/3 and its
> resend patch. However these 2 patches still remain. I'd really
> appreciate if someone reviewed them.
I asked on April 3 which upstream tree you expect this patchset to go
through and I did not see a reply. Do you have a specific target or is
the large addressee list assuming someone else is taking this set? All
we have seen is that it is not intended to go through the audit tree.
> Thanks
> Amol
- RGB
--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635
next prev parent reply other threads:[~2020-05-25 13:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 5:56 [PATCH 1/3 RESEND] sched: Remove __rcu annotation from cred pointer Amol Grover
2020-04-02 5:56 ` [PATCH 2/3 RESEND] cred: Do not use RCU primitives to access " Amol Grover
2020-04-02 5:56 ` [PATCH 3/3 RESEND] auditsc: Do not use RCU primitive to read from " Amol Grover
2020-04-02 12:56 ` Paul Moore
2020-04-03 7:56 ` Amol Grover
2020-04-03 19:25 ` Paul Moore
2020-04-03 21:21 ` Richard Guy Briggs
2020-04-03 21:43 ` Paul Moore
2020-04-04 2:53 ` Richard Guy Briggs
2020-05-24 8:11 ` [PATCH 1/3 RESEND] sched: Remove __rcu annotation " Amol Grover
2020-05-25 13:17 ` Richard Guy Briggs [this message]
2020-05-25 18:04 ` Amol Grover
2020-05-26 12:34 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525131741.s6lgb263fpo5uszk@madcap2.tricolour.ca \
--to=rgb@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bsegall@google.com \
--cc=dhowells@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=frextrite@gmail.com \
--cc=jamorris@linux.microsoft.com \
--cc=jannh@google.com \
--cc=joel@joelfernandes.org \
--cc=juri.lelli@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhuparnabhowmik10@gmail.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=paul@paul-moore.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shakeelb@google.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).