From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: avoid inifinite loop to wait for flushing node pages at cp_error
Date: Mon, 25 May 2020 08:06:08 -0700 [thread overview]
Message-ID: <20200525150608.GA55033@google.com> (raw)
In-Reply-To: <565af47c-8364-d910-8d1c-93645c12e660@huawei.com>
On 05/25, Chao Yu wrote:
> On 2020/5/25 11:56, Jaegeuk Kim wrote:
> > Shutdown test is somtimes hung, since it keeps trying to flush dirty node pages
>
> IMO, for umount case, we should drop dirty reference and dirty pages on meta/data
> pages like we change for node pages to avoid potential dead loop...
I believe we're doing for them. :P
>
> Thanks,
>
> > in an inifinite loop. Let's drop dirty pages at umount in that case.
> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> > v3:
> > - fix wrong unlock
> >
> > v2:
> > - fix typos
> >
> > fs/f2fs/node.c | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> > index e632de10aedab..e0bb0f7e0506e 100644
> > --- a/fs/f2fs/node.c
> > +++ b/fs/f2fs/node.c
> > @@ -1520,8 +1520,15 @@ static int __write_node_page(struct page *page, bool atomic, bool *submitted,
> >
> > trace_f2fs_writepage(page, NODE);
> >
> > - if (unlikely(f2fs_cp_error(sbi)))
> > + if (unlikely(f2fs_cp_error(sbi))) {
> > + if (is_sbi_flag_set(sbi, SBI_IS_CLOSE)) {
> > + ClearPageUptodate(page);
> > + dec_page_count(sbi, F2FS_DIRTY_NODES);
> > + unlock_page(page);
> > + return 0;
> > + }
> > goto redirty_out;
> > + }
> >
> > if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING)))
> > goto redirty_out;
> >
next prev parent reply other threads:[~2020-05-25 15:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 14:47 [PATCH] f2fs: avoid inifinite loop to wait for flushing node pages at cp_error Jaegeuk Kim
2020-05-22 23:32 ` Jaegeuk Kim
2020-05-25 3:56 ` [PATCH v3] " Jaegeuk Kim
2020-05-25 6:30 ` [f2fs-dev] " Chao Yu
2020-05-25 15:06 ` Jaegeuk Kim [this message]
2020-05-26 1:11 ` Chao Yu
2020-05-26 1:34 ` Chao Yu
2020-05-26 1:56 ` Jaegeuk Kim
2020-05-27 2:35 ` Chao Yu
2020-05-27 20:56 ` Jaegeuk Kim
2020-05-28 1:20 ` Chao Yu
2020-05-25 2:16 ` [f2fs-dev] [PATCH] " Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525150608.GA55033@google.com \
--to=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).