From: David Miller <davem@davemloft.net>
To: alexander.sverdlin@nokia.com
Cc: netdev@vger.kernel.org, edumazet@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] macvlan: Skip loopback packets in RX handler
Date: Tue, 26 May 2020 23:18:59 -0700 (PDT) [thread overview]
Message-ID: <20200526.231859.398097568630300979.davem@davemloft.net> (raw)
In-Reply-To: <20200526122751.409917-1-alexander.sverdlin@nokia.com>
From: Alexander A Sverdlin <alexander.sverdlin@nokia.com>
Date: Tue, 26 May 2020 14:27:51 +0200
> From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
>
> Ignore loopback-originatig packets soon enough and don't try to process L2
> header where it doesn't exist. The very similar br_handle_frame() in bridge
> code performs exactly the same check.
>
> This is an example of such ICMPv6 packet:
...
> Call Trace, how it happens exactly:
> ...
> macvlan_handle_frame+0x321/0x425 [macvlan]
> ? macvlan_forward_source+0x110/0x110 [macvlan]
> __netif_receive_skb_core+0x545/0xda0
...
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Applied to net-next, thanks.
prev parent reply other threads:[~2020-05-27 6:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 12:27 [PATCH] macvlan: Skip loopback packets in RX handler Alexander A Sverdlin
2020-05-27 6:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526.231859.398097568630300979.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.sverdlin@nokia.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).