From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2ECDC433E0 for ; Wed, 27 May 2020 04:21:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 859BC207D3 for ; Wed, 27 May 2020 04:21:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ozlabs.org header.i=@ozlabs.org header.b="Uuow4kSI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728769AbgE0EVD (ORCPT ); Wed, 27 May 2020 00:21:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728755AbgE0EVC (ORCPT ); Wed, 27 May 2020 00:21:02 -0400 Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DE4AC061A0F; Tue, 26 May 2020 21:21:02 -0700 (PDT) Received: by ozlabs.org (Postfix, from userid 1003) id 49WyLh5X25z9sSd; Wed, 27 May 2020 14:21:00 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1590553260; bh=cwG4p+fURpnXHo+TvskpLnMDdkg5NzfuxIxjhvAlZBs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uuow4kSIZoBpudeIAEjeRUhg6WZ/qKlgzuTlrmt7o1LcuYWuviCtfSzgYEdaCVTDf HAujJrHQXHdA0LzSL8BShz4enX0Vd4uuPREjUq+a+z0B/fgwO2PFq6AWXHr8Q5NDPq lqZbFHZy4loznYFO8KrR6x4ud3PsAqRkMxXOJOHhdpYGqntmDbd9EsxLiCMkGbjIJ7 civPT9ubEaEe0bvn2Atua3R8FbSDPEPpOnnFiOjL9Q/Za6Mrzlmfuj3cG2FGUgJD6z uR7jXTJwQnTnhXHn50MT6Df5rSaZMpV4OsQgdjlLJw/VPlTNhcuHiJzSB6Af23sprs b/mgQEtnVQbOA== Date: Wed, 27 May 2020 14:19:53 +1000 From: Paul Mackerras To: Qian Cai Cc: mpe@ellerman.id.au, benh@kernel.crashing.org, catalin.marinas@arm.com, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/kvm/radix: ignore kmemleak false positives Message-ID: <20200527041953.GF293451@thinks.paulus.ozlabs.org> References: <20200513133915.1040-1-cai@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513133915.1040-1-cai@lca.pw> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 13, 2020 at 09:39:15AM -0400, Qian Cai wrote: > kvmppc_pmd_alloc() and kvmppc_pte_alloc() allocate some memory but then > pud_populate() and pmd_populate() will use __pa() to reference the newly > allocated memory. > > Since kmemleak is unable to track the physical memory resulting in false > positives, silence those by using kmemleak_ignore(). > > unreferenced object 0xc000201c382a1000 (size 4096): > comm "qemu-kvm", pid 124828, jiffies 4295733767 (age 341.250s) > hex dump (first 32 bytes): > c0 00 20 09 f4 60 03 87 c0 00 20 10 72 a0 03 87 .. ..`.... .r... > c0 00 20 0e 13 a0 03 87 c0 00 20 1b dc c0 03 87 .. ....... ..... > backtrace: > [<000000004cc2790f>] kvmppc_create_pte+0x838/0xd20 [kvm_hv] > kvmppc_pmd_alloc at arch/powerpc/kvm/book3s_64_mmu_radix.c:366 > (inlined by) kvmppc_create_pte at arch/powerpc/kvm/book3s_64_mmu_radix.c:590 > [<00000000d123c49a>] kvmppc_book3s_instantiate_page+0x2e0/0x8c0 [kvm_hv] > [<00000000bb549087>] kvmppc_book3s_radix_page_fault+0x1b4/0x2b0 [kvm_hv] > [<0000000086dddc0e>] kvmppc_book3s_hv_page_fault+0x214/0x12a0 [kvm_hv] > [<000000005ae9ccc2>] kvmppc_vcpu_run_hv+0xc5c/0x15f0 [kvm_hv] > [<00000000d22162ff>] kvmppc_vcpu_run+0x34/0x48 [kvm] > [<00000000d6953bc4>] kvm_arch_vcpu_ioctl_run+0x314/0x420 [kvm] > [<000000002543dd54>] kvm_vcpu_ioctl+0x33c/0x950 [kvm] > [<0000000048155cd6>] ksys_ioctl+0xd8/0x130 > [<0000000041ffeaa7>] sys_ioctl+0x28/0x40 > [<000000004afc4310>] system_call_exception+0x114/0x1e0 > [<00000000fb70a873>] system_call_common+0xf0/0x278 > unreferenced object 0xc0002001f0c03900 (size 256): > comm "qemu-kvm", pid 124830, jiffies 4295735235 (age 326.570s) > hex dump (first 32 bytes): > c0 00 20 10 fa a0 03 87 c0 00 20 10 fa a1 03 87 .. ....... ..... > c0 00 20 10 fa a2 03 87 c0 00 20 10 fa a3 03 87 .. ....... ..... > backtrace: > [<0000000023f675b8>] kvmppc_create_pte+0x854/0xd20 [kvm_hv] > kvmppc_pte_alloc at arch/powerpc/kvm/book3s_64_mmu_radix.c:356 > (inlined by) kvmppc_create_pte at arch/powerpc/kvm/book3s_64_mmu_radix.c:593 > [<00000000d123c49a>] kvmppc_book3s_instantiate_page+0x2e0/0x8c0 [kvm_hv] > [<00000000bb549087>] kvmppc_book3s_radix_page_fault+0x1b4/0x2b0 [kvm_hv] > [<0000000086dddc0e>] kvmppc_book3s_hv_page_fault+0x214/0x12a0 [kvm_hv] > [<000000005ae9ccc2>] kvmppc_vcpu_run_hv+0xc5c/0x15f0 [kvm_hv] > [<00000000d22162ff>] kvmppc_vcpu_run+0x34/0x48 [kvm] > [<00000000d6953bc4>] kvm_arch_vcpu_ioctl_run+0x314/0x420 [kvm] > [<000000002543dd54>] kvm_vcpu_ioctl+0x33c/0x950 [kvm] > [<0000000048155cd6>] ksys_ioctl+0xd8/0x130 > [<0000000041ffeaa7>] sys_ioctl+0x28/0x40 > [<000000004afc4310>] system_call_exception+0x114/0x1e0 > [<00000000fb70a873>] system_call_common+0xf0/0x278 > > Signed-off-by: Qian Cai Thanks, applied to my kvm-ppc-next branch. Paul.